search

openshift / check-payload

Apache License 2.0
12 stars 35 forks source link

Fix braces #183

Closed dominikholler closed 4 months ago

dominikholler commented 4 months ago

The single "[" resulted in ignoring the following lines in the config file.

In addition, payload.operator-lifecycle-manager-container and payload.ose-olm-rukpak-container are missing the error to mask.

dominikholler commented 4 months ago

@kolyshkin @rphillips can you please review?

openshift-ci[bot] commented 4 months ago

@dominikholler: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rphillips commented 4 months ago

/lgtm /approve

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dominikholler, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/check-payload/blob/main/OWNERS)~~ [rphillips] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment