int/types: rm NewDefaultConfig

openshift / check-payload

Apache License 2.0

10 stars 28 forks source link

int/types: rm NewDefaultConfig #191

Closed kolyshkin closed 4 weeks ago

kolyshkin commented 4 weeks ago

The NewDefaultConfig method has a few issues:

its name is misleading (it does not create a new object);
it is only used in tests (and thus do not belong to non-test codebase);
it has quite a few inits that are redundant.

Remove it, and add a simple init right to the test case. We can move it out to a separate function in test later if need arises.

openshift-ci[bot] commented 4 weeks ago

@kolyshkin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

openshift-ci[bot] commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kolyshkin, rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/check-payload/blob/main/OWNERS)~~ [kolyshkin,rhmdnd] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment