search

openshift / check-payload

Apache License 2.0
10 stars 28 forks source link

set info.Certified as false, if empty string #201

Closed ashwindasr closed 1 week ago

ashwindasr commented 1 week ago

Follows https://github.com/openshift/check-payload/pull/175

openshift-enterprise-pod-container was passing scan if -V 4.16 was set, even though it was not mentioned in the excludes

thead here

ashwindasr commented 1 week ago

/cc @rhmdnd

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ashwindasr Once this PR has been reviewed and has the lgtm label, please assign rphillips for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/check-payload/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ashwindasr commented 1 week ago

/hold

The error might be in a different place. sudo ./check-payload -V 4.16 scan image --spec registry-proxy.engineering.redhat.com/rh-osbs/openshift-ose-pod-rhel9@sha256:856bcc5a915f5af7dd6bfb35faa54ecb78e350c4ca5adb01d49df8915d3bb258 still passes when it should have been failing

openshift-ci[bot] commented 1 week ago

@ashwindasr: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify 70a10dae85f9d9f4a3fd598392597ee0078cbb76 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
ashwindasr commented 1 week ago

/close

In favor of https://github.com/openshift/check-payload/pull/202

openshift-ci[bot] commented 1 week ago

@ashwindasr: Closed this PR.

In response to [this](https://github.com/openshift/check-payload/pull/201#issuecomment-2189551158): >/close > >In favor of https://github.com/openshift/check-payload/pull/202 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.