Closed rhmdnd closed 4 days ago
@rhmdnd: This pull request references CMP-2639 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.
@rhmdnd: all tests passed!
Full PR test history. Your PR dashboard.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mrunalp, rhmdnd
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Golang version 1.22 does not have hardcoded libcrypto versions anymore, and does not emit the libcrypto version in the binary output of a go binary (e.g., using strings).
Because of this, the approach we were using to detect the OpenSSL version based on a regular expression and attempting to match that with the binary output does not work for binaries built with golang 1.22.
This is particularly prevalent with OpenShift 4.17 payloads that are using RHEL 9 and golang 1.22 base images.
This commit updates the binary scan logic to skip checking binaries for OpenSSL versions when using golang 1.22.