search

openshift / ci-operator

28 stars 59 forks source link

`clonerefs` output is ignored, so tests can run with with incorrect refs #183

Open stevekuznetsov opened 6 years ago

stevekuznetsov commented 6 years ago

We ignore the output of clonerefs due to https://github.com/openshift/ci-operator/commit/7ad9489ab5f502d7b40fdd33df6ca508a84f7697 and https://github.com/openshift/ci-operator/commit/9aa7a8a12785307fb33d22920d53fced467187df.

That's simply wrong and must be fixed.

We should either run initupload or write the log and read it ourselves, the output is simple.

If we had done this, the master-dockerless-build-temporary issue would not have happened.

/assign @smarterclayton

smarterclayton commented 6 years ago

You mean, we should have read the log to find out that clone failed?

stevekuznetsov commented 6 years ago

Thats exactly the (well documented) API for the tool...