Closed stevekuznetsov closed 9 months ago
cc @jstuever
Ideally we would add an ensure-mockgen
target to build-machinery-go.
However, installing go tools seems not to work consistently (le big sad face). But perhaps something like this would be useful.
@2uasimojo what's wrong with go install
that makes it unreliable? In previous projects I found that using a temporary go.mod
file and go install
(to not pollute the project's dependencies itself) was very fruitful for this sort of stuff.
@stevekuznetsov I'll be the first to admit I've never had a good grasp on go's dependency or module or helper binary setups. I've never heard of
using a temporary
go.mod
file
but if that makes it work consistently, great! Let's do the same for ensure-imagebuilder
!
@2uasimojo sure thing! I'll update both. FWIW This is the go mod
impl:
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen
.
If this issue is safe to close now please do so with /close
.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten
.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen
.
If this issue is safe to close now please do so with /close
.
/lifecycle rotten /remove-lifecycle stale
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting /reopen
.
Mark the issue as fresh by commenting /remove-lifecycle rotten
.
Exclude this issue from closing again by commenting /lifecycle frozen
.
/close
@openshift-bot: Closing this issue.
Today the
mockgen
binary is used to generate mocks for the cloud-specific client packages, but the generator's not installed viamake
and the version of the generator is not validated to be correct when runningmake generate
. Furthermore, the mocks are not validated to be correct in CI.Today, the correct version is
Ideally we have:
make
target to install this toolmake
target as a dependency formake generate
to validate that the version ofmockgen
being run is correctmake
target undermake validate
that ensures the mocks are not changed when re-generated, to ensure they are up to datecc @abutcher