search

openshift / cloud-credential-operator

Manage cloud provider credentials as Kubernetes CRDs
Apache License 2.0
62 stars 145 forks source link

[release-4.15] OCPBUGS-27919: Report manualpodidentity mode in metrics when using Azure Workload Identity #661

Closed openshift-cherrypick-robot closed 9 months ago

openshift-cherrypick-robot commented 9 months ago

This is an automated cherry-pick of #657

/assign jstuever

openshift-ci-robot commented 9 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-27446 has been cloned as Jira Issue OCPBUGS-27919. Will retitle bug to link to clone. /retitle [release-4.15] OCPBUGS-27919: Report manualpodidentity mode in metrics when using Azure Workload Identity

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/661): >This is an automated cherry-pick of #657 > >/assign jstuever Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 9 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-27919, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.0) matches configured target version for branch (4.15.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-27446](https://issues.redhat.com//browse/OCPBUGS-27446) is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-27446](https://issues.redhat.com//browse/OCPBUGS-27446) targets the "4.16.0" version, which is one of the valid target versions: 4.16.0 * bug has dependents

Requesting review from QA contact: /cc @jianping-shu

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/661): >This is an automated cherry-pick of #657 > >/assign jstuever Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (67842c7) 48.34% compared to head (2b63f55) 48.37%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/661/graphs/tree.svg?width=650&height=150&src=pr&token=MSJhsyXrnA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/661?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## release-4.15 #661 +/- ## ================================================ + Coverage 48.34% 48.37% +0.03% ================================================ Files 96 96 Lines 11780 11783 +3 ================================================ + Hits 5695 5700 +5 + Misses 5452 5450 -2 Partials 633 633 ``` | [Files](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/661?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [pkg/operator/metrics/metrics.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/661?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL29wZXJhdG9yL21ldHJpY3MvbWV0cmljcy5nbw==) | `47.34% <100.00%> (+1.93%)` | :arrow_up: |
jianping-shu commented 9 months ago

Verified with cluster-bot build 4.15.0-0.ci.test-2024-01-25-074018-ci-ln-tvc4n2b-latest. Azure workload identity cluster installed successfully. The metric cco_credentials_mode is manualpodidentity now.

_Metric data record: cco_credentialsmode kube-rbac-proxy metrics 10.130.0.28:8443 cco-metrics manualpodidentity openshift-cloud-credential-operator cloud-credential-operator-7ddc464dc5-fzjbn openshift-monitoring/k8s cco-metrics 1

jianping-shu commented 9 months ago

/label cherry-pick-approved

jstuever commented 9 months ago

/lgtm /approve

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cloud-credential-operator/blob/release-4.15/OWNERS)~~ [jstuever] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jstuever commented 9 months ago

/label backport-risk-assessed

jstuever commented 9 months ago

/override ci/prow/security

openshift-ci[bot] commented 9 months ago

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/661#issuecomment-1911139351): >/override ci/prow/security Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 9 months ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 9 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-27919: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-27919 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/661): >This is an automated cherry-pick of #657 > >/assign jstuever Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.