search

openshift / cloud-credential-operator

Manage cloud provider credentials as Kubernetes CRDs
Apache License 2.0
62 stars 145 forks source link

OCPBUGS-16646: GCP to use full project path when testing iam passthrough permissions. #662

Closed jstuever closed 8 months ago

jstuever commented 9 months ago

This change switches from using the GCP project name to the project fully qualified name when testing if the passthrough service account has sufficient permissions. This removes the possibility of collision when other resources have the same name as the project. This should remove the 400 errors for permission being invalid for the wrong resource by these collisions.

openshift-ci-robot commented 9 months ago

@jstuever: This pull request references Jira Issue OCPBUGS-16646, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/662): >This change switches from using the GCP project name to the project fully qualified name when testing if the passthrough service account has sufficient permissions. This removes the possibility of collision when other resources have the same name as the project. This should remove the 400 errors for permission being invalid for the wrong resource by these collisions. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cloud-credential-operator/blob/master/OWNERS)~~ [jstuever] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jstuever commented 9 months ago

/jira refresh

openshift-ci-robot commented 9 months ago

@jstuever: This pull request references Jira Issue OCPBUGS-16646, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @jianping-shu

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/662#issuecomment-1909174018): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jstuever commented 9 months ago

/hold for testing.

openshift-ci[bot] commented 9 months ago

@jstuever: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 9953aa796e506d1ce932a5467a435c59f381d523 link true /test unit
ci/prow/e2e-upgrade 9953aa796e506d1ce932a5467a435c59f381d523 link true /test e2e-upgrade
ci/prow/verify 9953aa796e506d1ce932a5467a435c59f381d523 link true /test verify
ci/prow/coverage 9953aa796e506d1ce932a5467a435c59f381d523 link true /test coverage
ci/prow/security 9953aa796e506d1ce932a5467a435c59f381d523 link true /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 8 months ago

@jstuever: This pull request references Jira Issue OCPBUGS-16646. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/662): >This change switches from using the GCP project name to the project fully qualified name when testing if the passthrough service account has sufficient permissions. This removes the possibility of collision when other resources have the same name as the project. This should remove the 400 errors for permission being invalid for the wrong resource by these collisions. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.