search

openshift / cloud-credential-operator

Manage cloud provider credentials as Kubernetes CRDs
Apache License 2.0
62 stars 143 forks source link

[release-4.15] OCPBUGS-29113: ccoctl - use proxy when validating CloudFront URL #674

Closed openshift-cherrypick-robot closed 7 months ago

openshift-cherrypick-robot commented 7 months ago

This is an automated cherry-pick of #654

/assign jstuever

openshift-ci-robot commented 7 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-27214 has been cloned as Jira Issue OCPBUGS-29113. Will retitle bug to link to clone. /retitle [release-4.15] OCPBUGS-29113: ccoctl - use proxy when validating CloudFront URL

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/674): >This is an automated cherry-pick of #654 > >/assign jstuever Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 7 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-29113, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.0) matches configured target version for branch (4.15.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-27214](https://issues.redhat.com//browse/OCPBUGS-27214) is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-27214](https://issues.redhat.com//browse/OCPBUGS-27214) targets the "4.16.0" version, which is one of the valid target versions: 4.16.0 * bug has dependents

Requesting review from QA contact: /cc @jianping-shu

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/674): >This is an automated cherry-pick of #654 > >/assign jstuever Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jstuever commented 7 months ago

/cherry-pick release-4.14

openshift-cherrypick-robot commented 7 months ago

@jstuever: once the present PR merges, I will cherry-pick it on top of release-4.14 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/674#issuecomment-1930511512): >/cherry-pick release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codecov[bot] commented 7 months ago

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (1268354) 48.37% compared to head (27ce4f2) 48.36%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/674/graphs/tree.svg?width=650&height=150&src=pr&token=MSJhsyXrnA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## release-4.15 #674 +/- ## ================================================ - Coverage 48.37% 48.36% -0.01% ================================================ Files 96 96 Lines 11784 11786 +2 ================================================ Hits 5700 5700 - Misses 5451 5452 +1 - Partials 633 634 +1 ``` | [Files](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [...g/cmd/provisioning/aws/create\_identity\_provider.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/674?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2NtZC9wcm92aXNpb25pbmcvYXdzL2NyZWF0ZV9pZGVudGl0eV9wcm92aWRlci5nbw==) | `65.32% <60.00%> (-0.36%)` | :arrow_down: |
jstuever commented 7 months ago

/retest

jstuever commented 7 months ago

/test e2e-aws-manual-oidc

openshift-ci[bot] commented 7 months ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jianping-shu commented 7 months ago

Verified with cluster-bot build. Regression tests: aws sts cluster with the public s3 installed successfully aws sts cluster with the private s3 installed successfully

jianping-shu commented 7 months ago

/label cherry-pick-approved

jstuever commented 7 months ago

/label backport-risk-assessed

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cloud-credential-operator/blob/release-4.15/OWNERS)~~ [jstuever] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 7 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-29113: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29113 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/674): >This is an automated cherry-pick of #654 > >/assign jstuever Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 7 months ago

@jstuever: new pull request created: #678

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/674#issuecomment-1930511512): >/cherry-pick release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 7 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cloud-credential-operator-container-v4.15.0-202402080306.p0.gc9fd580.assembly.stream.el8 for distgit ose-cloud-credential-operator. All builds following this will include this PR.