openshift / cloud-credential-operator

Manage cloud provider credentials as Kubernetes CRDs
Apache License 2.0
62 stars 143 forks source link

CCO-525: Azure workload identity doc updates #680

Closed jstuever closed 6 months ago

jstuever commented 7 months ago
sdodson commented 7 months ago

/lgtm /hold In case anyone else wishes to review too.

julienlim commented 7 months ago

OCPSTRAT-1185 is the feature JIRA for this one.

jstuever commented 6 months ago

/retitle CCO-525: Azure workload identity doc updates

openshift-ci-robot commented 6 months ago

@jstuever: This pull request references CCO-525 which is a valid jira issue.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/680): >- Converted numbered lists to use dynamic numbering. >- Updated install steps to take advantage of oc --included option when extracting credential requests. >- Switched to rebooting machine config pools instead of restarting all pods. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jstuever commented 6 months ago

/jira refresh

openshift-ci-robot commented 6 months ago

@jstuever: This pull request references CCO-525 which is a valid jira issue.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/680#issuecomment-1957772819): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jstuever commented 6 months ago

/assign @dlom

dlom commented 6 months ago

/lgtm

Should be good to unhold at your leisure @jstuever

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom, jstuever, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cloud-credential-operator/blob/master/OWNERS)~~ [dlom,jstuever] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jstuever commented 6 months ago

/hold cancel

openshift-bot commented 6 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cloud-credential-operator-container-v4.16.0-202402212311.p0.gc4b7760.assembly.stream.el8 for distgit ose-cloud-credential-operator. All builds following this will include this PR.