[release-4.15] OCPBUGS-30412: gcp actuator update check to consider custom roles

[openshift-cherrypick-robot]

This is an automated cherry-pick of #685

/assign jstuever

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-28787 has been cloned as Jira Issue OCPBUGS-30412. Will retitle bug to link to clone. /retitle [release-4.15] OCPBUGS-30412: gcp actuator update check to consider custom roles

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/686): >This is an automated cherry-pick of #685 > >/assign jstuever Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-30412, which is invalid:

• expected dependent Jira Issue OCPBUGS-28787 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/686): >This is an automated cherry-pick of #685 > >/assign jstuever Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 18.18182% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 48.32%. Comparing base (9adc8f6) to head (c38502a).

Additional details and impacted files

[](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/686?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## release-4.15 #686 +/- ## ================================================ - Coverage 48.34% 48.32% -0.02% ================================================ Files 96 96 Lines 11791 11800 +9 ================================================ + Hits 5700 5702 +2 - Misses 5457 5464 +7 Partials 634 634 ``` | [Files](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/686?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [pkg/gcp/actuator/policy.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/686?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2djcC9hY3R1YXRvci9wb2xpY3kuZ28=) | `66.30% <18.18%> (-2.27%)` | :arrow_down: |

[jianping-shu]

/jira refresh

[openshift-ci-robot]

@jianping-shu: This pull request references Jira Issue OCPBUGS-30412, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.15.z) matches configured target version for branch (4.15.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-28787](https://issues.redhat.com//browse/OCPBUGS-28787) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-28787](https://issues.redhat.com//browse/OCPBUGS-28787) targets the "4.16.0" version, which is one of the valid target versions: 4.16.0 * bug has dependents

Requesting review from QA contact: /cc @jianping-shu

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/686#issuecomment-1982216611): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[jianping-shu]

/retest

[jianping-shu]

Verified with cluster-bot build.

1. GCP Mint cluster installed successfully jianpingshu@jshu-mac ~ % oc get clusterversion NAME VERSION AVAILABLE PROGRESSING SINCE STATUS version 4.15.0-0.ci.test-2024-03-07-022759-ci-ln-8cn0x2t-latest True False 5h50m Cluster version is 4.15.0-0.ci.test-2024-03-07-022759-ci-ln-8cn0x2t-latest jianpingshu@jshu-mac ~ % oc get secret -n kube-system gcp-credentials -o=jsonpath={.metadata.annotations} {"cloudcredential.openshift.io/mode":"mint"}
2. Delete the root credential jianpingshu@jshu-mac ~ % oc delete secret -n kube-system gcp-credentials secret "gcp-credentials" deleted
3. Wait > 3h, no degrade jianpingshu@jshu-mac ~ % oc get co cloud-credential -o=jsonpath={.status.conditions} [{"lastTransitionTime":"2024-03-07T02:46:52Z","message":"All is well","reason":"AsExpected","status":"True","type":"Available"},{"lastTransitionTime":"2024-03-07T02:48:07Z","message":"All is well","reason":"AsExpected","status":"False","type":"Degraded"},{"lastTransitionTime":"2024-03-07T02:59:46Z","message":"All is well","reason":"AsExpected","status":"False","type":"Progressing"},{"lastTransitionTime":"2024-03-07T03:39:46Z","message":"Parent credentials secret must be restored prior to upgrade: kube-system/gcp-credentials","reason":"MissingRootCredential","status":"False","type":"Upgradeable"}]

[jianping-shu]

/label cherry-pick-approved

[jstuever]

/override ci/prow/security

[jstuever]

/label backport-risk-assessed

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cloud-credential-operator/blob/release-4.15/OWNERS)~~ [jstuever] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[openshift-ci[bot]]

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/686#issuecomment-1984048140): >/override ci/prow/security Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[openshift-ci[bot]]

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	c38502ab90cceab6210dffd824d7ceb15f17821d	link	true	/test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-30412: All pull requests linked via external trackers have merged:

• openshift/cloud-credential-operator#686

Jira Issue OCPBUGS-30412 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/686): >This is an automated cherry-pick of #685 > >/assign jstuever Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cloud-credential-operator-container-v4.15.0-202403071909.p0.g06a4294.assembly.stream.el8 for distgit ose-cloud-credential-operator. All builds following this will include this PR.