search

openshift / cloud-credential-operator

Manage cloud provider credentials as Kubernetes CRDs
Apache License 2.0
62 stars 145 forks source link

OCPBUGS-30713: update go-jose module to v4.0.1 #687

Closed jstuever closed 7 months ago

jstuever commented 7 months ago

Update go-jose module to v4.0.1

openshift-ci-robot commented 7 months ago

@jstuever: This pull request references Jira Issue OCPBUGS-30713, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @jianping-shu

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/687): >Update go-jose module to v4.0.1 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.34%. Comparing base (9bad012) to head (7063f8c).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/687/graphs/tree.svg?width=650&height=150&src=pr&token=MSJhsyXrnA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #687 +/- ## ======================================= Coverage 48.34% 48.34% ======================================= Files 96 96 Lines 11799 11799 ======================================= Hits 5704 5704 Misses 5462 5462 Partials 633 633 ``` | [Files](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/687?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [...g/cmd/provisioning/aws/create\_identity\_provider.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2NtZC9wcm92aXNpb25pbmcvYXdzL2NyZWF0ZV9pZGVudGl0eV9wcm92aWRlci5nbw==) | `65.32% <ø> (ø)` | | | [pkg/cmd/provisioning/utils.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/687?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2NtZC9wcm92aXNpb25pbmcvdXRpbHMuZ28=) | `77.77% <ø> (ø)` | |
2uasimojo commented 7 months ago

Plan to upgrade protobuf separately?

jstuever commented 7 months ago

/test e2e-aws-manual-oidc

jstuever commented 7 months ago

/hold for e2e-aws-manual-oidc /override ci/prow/security

openshift-ci[bot] commented 7 months ago

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/687#issuecomment-1995891998): >/hold for e2e-aws-manual-oidc >/override ci/prow/security Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
jianping-shu commented 7 months ago

Verified with cluster-bot build. AWS STS cluster installed successfully. Regression tested with OCP-36498/34470/48360/50869/64885.

jianping-shu commented 7 months ago

/retest

openshift-ci[bot] commented 7 months ago

@jstuever: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jstuever commented 7 months ago

/assign @dlom /hold cancel

dlom commented 7 months ago

/lgtm

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cloud-credential-operator/blob/master/OWNERS)~~ [dlom,jstuever] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 7 months ago

@jstuever: Jira Issue OCPBUGS-30713: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30713 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/687): >Update go-jose module to v4.0.1 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 7 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cloud-credential-operator-container-v4.16.0-202403270213.p0.gba78216.assembly.stream.el8 for distgit ose-cloud-credential-operator. All builds following this will include this PR.