search

openshift / cloud-credential-operator

Manage cloud provider credentials as Kubernetes CRDs
Apache License 2.0
62 stars 143 forks source link

OCPBUGS-33621: docs: Azure WI migration to extract only the credentialRequests needed by the cluster. #702

Closed jstuever closed 3 months ago

jstuever commented 4 months ago

Update the Azure workload identity migration steps to utilize the oc adm extract --included option to select the proper credentialRequests for the cluster as opposed to trying to determine and use a release image.

openshift-ci-robot commented 4 months ago

@jstuever: This pull request references Jira Issue OCPBUGS-33621, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/702): >Update the Azure workload identity migration steps to utilize the oc adm extract --included option to select the proper credentialRequests for the cluster as opposed to trying to determine and use a release image. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jstuever commented 4 months ago

/jira refresh

openshift-ci-robot commented 4 months ago

@jstuever: This pull request references Jira Issue OCPBUGS-33621, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @huangmingxia

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/702#issuecomment-2113404646): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 months ago

@jstuever: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
huangmingxia commented 3 months ago

LGTM

[hmx@fedora az-dis]$ oc adm release extract --credentials-requests --included --to credreqs --registry-config ~/.pull-secret
Extracted release payload created at 2024-05-16T09:25:45Z
[hmx@fedora az-dis]$ ll credreqs
total 28
-rw-r--r--. 1 hmx hmx 1330 May 17 16:55 0000_26_cloud-controller-manager-operator_14_credentialsrequest-azure.yaml
-rw-r--r--. 1 hmx hmx 2330 May 17 16:55 0000_30_machine-api-operator_00_credentials-request.yaml
-rw-r--r--. 1 hmx hmx 2589 May 17 16:55 0000_50_cluster-image-registry-operator_01-registry-credentials-request-azure.yaml
-rw-r--r--. 1 hmx hmx 1011 May 17 16:55 0000_50_cluster-ingress-operator_00-ingress-credentials-request.yaml
-rw-r--r--. 1 hmx hmx 1034 May 17 16:55 0000_50_cluster-network-operator_02-cncc-credentials.yaml
-rw-r--r--. 1 hmx hmx 1332 May 17 16:55 0000_50_cluster-storage-operator_03_credentials_request_azure_file.yaml
-rw-r--r--. 1 hmx hmx 1082 May 17 16:55 0000_50_cluster-storage-operator_03_credentials_request_azure.yaml
jstuever commented 3 months ago

/assign @dlom /label acknowledge-critical-fixes-only

dlom commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cloud-credential-operator/blob/master/OWNERS)~~ [dlom,jstuever] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 months ago

@jstuever: Jira Issue OCPBUGS-33621: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33621 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/702): >Update the Azure workload identity migration steps to utilize the oc adm extract --included option to select the proper credentialRequests for the cluster as opposed to trying to determine and use a release image. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.