search

openshift / cloud-credential-operator

Manage cloud provider credentials as Kubernetes CRDs
Apache License 2.0
62 stars 143 forks source link

[release-4.16] OCPBUGS-34117: AWS STS should not error when a credentailsRequest does not have awsSTSIAMRoleARN #704

Closed openshift-cherrypick-robot closed 2 months ago

openshift-cherrypick-robot commented 3 months ago

This is an automated cherry-pick of #703

/assign jstuever

openshift-ci-robot commented 3 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-33566 has been cloned as Jira Issue OCPBUGS-34117. Will retitle bug to link to clone. /retitle [release-4.16] OCPBUGS-34117: AWS STS should not error when a credentailsRequest does not have awsSTSIAMRoleARN

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/704): >This is an automated cherry-pick of #703 > >/assign jstuever Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-34117, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/704): >This is an automated cherry-pick of #703 > >/assign jstuever Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.35%. Comparing base (48b287d) to head (2401b32).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/704/graphs/tree.svg?width=650&height=150&src=pr&token=MSJhsyXrnA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/704?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## release-4.16 #704 +/- ## ============================================= Coverage 48.34% 48.35% ============================================= Files 96 96 Lines 11799 11797 -2 ============================================= Hits 5704 5704 + Misses 5462 5460 -2 Partials 633 633 ``` | [Files](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/704?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [pkg/aws/actuator/actuator.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/704?src=pr&el=tree&filepath=pkg%2Faws%2Factuator%2Factuator.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2F3cy9hY3R1YXRvci9hY3R1YXRvci5nbw==) | `64.06% <50.00%> (+0.15%)` | :arrow_up: |
jstuever commented 3 months ago

/retest-required /override ci/prow/security

openshift-ci[bot] commented 3 months ago

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/704#issuecomment-2125276386): >/retest-required >/override ci/prow/security Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jianping-shu commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@jianping-shu: This pull request references Jira Issue OCPBUGS-34117, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-33566](https://issues.redhat.com//browse/OCPBUGS-33566) is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-33566](https://issues.redhat.com//browse/OCPBUGS-33566) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @jianping-shu

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/704#issuecomment-2131810436): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jianping-shu commented 3 months ago

Verified with cluster-bot build. AWS STS cluster installed successfully. No error log "empty awsSTSIAMRoleARN" any more.

jianpingshu@jshu-mac ~ % oc get clusterversion NAME VERSION AVAILABLE PROGRESSING SINCE STATUS version 4.16.0-0.ci.test-2024-05-26-010010-ci-ln-6r9dy9t-latest True False 38m Cluster version is 4.16.0-0.ci.test-2024-05-26-010010-ci-ln-6r9dy9t-latest

jianpingshu@jshu-mac ~ % oc -n openshift-cloud-credential-operator get -o json credentialsrequests | jq -r '.items[] | select(tostring | contains("InfrastructureMismatch") | not) | .metadata.name as $n | .status.conditions // [{type: "NoConditions"}] | .[] | .type + "=" + .status + " " + $n + " " + .reason + ": " + .message' | sort NoConditions= aws-ebs-csi-driver-operator : NoConditions= cloud-credential-operator-iam-ro : NoConditions= openshift-cloud-network-config-controller-aws : NoConditions= openshift-image-registry : NoConditions= openshift-ingress : NoConditions= openshift-machine-api-aws :

jianpingshu@jshu-mac ~ % oc logs cloud-credential-operator-785c8f9445-g8xgx -n openshift-cloud-credential-operator -c cloud-credential-operator > cloud-credential-operator-785c8f9445-g8xgx-416.log

jianpingshu@jshu-mac OCPBUGS-34117 % grep "an empty awsSTSIAMRoleARN was found" cloud-credential-operator-785c8f9445-g8xgx-416.log jianpingshu@jshu-mac OCPBUGS-34117 %

jianping-shu commented 3 months ago

/retest

jstuever commented 3 months ago

/retest

jianping-shu commented 3 months ago

/label cherry-pick-approved

jianping-shu commented 3 months ago

@jstuever Kindly remind this PR since 4.16 GA is upcoming.

jstuever commented 2 months ago

/cherry-pick release-6.15 release-6.14

openshift-cherrypick-robot commented 2 months ago

@jstuever: once the present PR merges, I will cherry-pick it on top of release-6.15 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/704#issuecomment-2192116766): >/cherry-pick release-6.15 release-6.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jstuever commented 2 months ago

/cherrypick release-6.15 release-6.14

openshift-cherrypick-robot commented 2 months ago

@jstuever: once the present PR merges, I will cherry-pick it on top of release-6.15 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/704#issuecomment-2192118335): >/cherrypick release-6.15 release-6.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cloud-credential-operator/blob/release-4.16/OWNERS)~~ [jstuever] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jstuever commented 2 months ago

/label backport-risk-assessed

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 48b287d41e71b23c55b00cbcbfb38ac1eedfb9f4 and 2 for PR HEAD 2401b324ce9ee49b66b372d1ff73b7e89307d4e0 in total

jstuever commented 2 months ago

/override ci/prow/security

openshift-ci[bot] commented 2 months ago

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/704#issuecomment-2195287915): >/override ci/prow/security Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 months ago

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 2401b324ce9ee49b66b372d1ff73b7e89307d4e0 link true /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-34117: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-34117 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/704): >This is an automated cherry-pick of #703 > >/assign jstuever Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 2 months ago

@jstuever: cannot checkout release-6.15: error checking out "release-6.15": exit status 1 error: pathspec 'release-6.15' did not match any file(s) known to git

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/704#issuecomment-2192118335): >/cherrypick release-6.15 release-6.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
wking commented 2 months ago

Fixing the presumed 6 vs 4 typo, to save Jeremiah some time.

/cherrypick release-4.15 release-4.14

openshift-cherrypick-robot commented 2 months ago

@wking: new pull request created: #709

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/704#issuecomment-2195502139): >Fixing [the presumed `6` vs `4` typo][1], to save Jeremiah some time. > >/cherrypick release-4.15 release-4.14 > >[1]: https://github.com/openshift/cloud-credential-operator/pull/704#issuecomment-2192116766 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cloud-credential-operator-container-v4.16.0-202406280629.p0.gc6c1b0b.assembly.stream.el9 for distgit ose-cloud-credential-operator. All builds following this will include this PR.