openshift / cloud-credential-operator

Manage cloud provider credentials as Kubernetes CRDs
Apache License 2.0
62 stars 143 forks source link

CCO-572: STS OLM for GCP (WIF) #708

Closed dlom closed 1 month ago

dlom commented 3 months ago

/hold /assign @jstuever xref: CCO-572

openshift-ci-robot commented 3 months ago

@dlom: This pull request references CCO-572 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/708): >/hold >/assign @jstuever >xref: [CCO-572](https://issues.redhat.com//browse/CCO-572) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 months ago

@dlom: This pull request references CCO-572 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/708): >/hold >/assign @jstuever >xref: [CCO-572](https://issues.redhat.com//browse/CCO-572) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 1.61290% with 61 lines in your changes missing coverage. Please review.

Project coverage is 46.53%. Comparing base (2f29d91) to head (0171530). Report is 16 commits behind head on master.

Files Patch % Lines
pkg/gcp/actuator/actuator.go 1.61% 59 Missing and 2 partials :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/708/graphs/tree.svg?width=650&height=150&src=pr&token=MSJhsyXrnA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/708?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #708 +/- ## ========================================== - Coverage 48.35% 46.53% -1.82% ========================================== Files 96 102 +6 Lines 11797 12259 +462 ========================================== + Hits 5704 5705 +1 - Misses 5460 5919 +459 - Partials 633 635 +2 ``` | [Files](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/708?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [pkg/gcp/actuator/actuator.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/708?src=pr&el=tree&filepath=pkg%2Fgcp%2Factuator%2Factuator.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2djcC9hY3R1YXRvci9hY3R1YXRvci5nbw==) | `50.64% <1.61%> (-6.35%)` | :arrow_down: | ... and [10 files with indirect coverage changes](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/708/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
dlom commented 1 month ago

/assign @jstuever

dlom commented 1 month ago

/override ci/prow/security

openshift-ci[bot] commented 1 month ago

@dlom: Overrode contexts on behalf of dlom: ci/prow/security

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/708#issuecomment-2243608351): >/override ci/prow/security Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dlom commented 1 month ago

/retest

jstuever commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

@dlom: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cloud-credential-operator/blob/master/OWNERS)~~ [dlom,jstuever] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dlom commented 1 month ago

/unhold

openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cloud-credential-operator This PR has been included in build ose-cloud-credential-operator-container-v4.17.0-202407310342.p0.g5d9a5c8.assembly.stream.el9. All builds following this will include this PR.