[release-4.15] OCPBUGS-36291: AWS STS should not error when a credentailsRequest does not have awsSTSIAMRoleARN

[openshift-cherrypick-robot]

This is an automated cherry-pick of #704

/assign wking

/cherrypick release-4.14

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-34117 has been cloned as Jira Issue OCPBUGS-36291. Will retitle bug to link to clone. /retitle [release-4.15] OCPBUGS-36291: AWS STS should not error when a credentailsRequest does not have awsSTSIAMRoleARN

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/709): >This is an automated cherry-pick of #704 > >/assign wking > >/cherrypick release-4.14 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-ci-robot]

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-36291, which is invalid:

• expected dependent Jira Issue OCPBUGS-34117 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/709): >This is an automated cherry-pick of #704 > >/assign wking > >/cherrypick release-4.14 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[jstuever]

/assign

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.33%. Comparing base (af5662f) to head (7d8fddd).

Additional details and impacted files

[](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/709?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## release-4.15 #709 +/- ## ============================================= Coverage 48.32% 48.33% ============================================= Files 96 96 Lines 11800 11798 -2 ============================================= Hits 5702 5702 + Misses 5464 5462 -2 Partials 634 634 ``` | [Files](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/709?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [pkg/aws/actuator/actuator.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/709?src=pr&el=tree&filepath=pkg%2Faws%2Factuator%2Factuator.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2F3cy9hY3R1YXRvci9hY3R1YXRvci5nbw==) | `64.06% <50.00%> (+0.15%)` | :arrow_up: |

[jstuever]

/override ci/prow/security

[jstuever]

/label backport-risk-assessed

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cloud-credential-operator/blob/release-4.15/OWNERS)~~ [jstuever] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[openshift-ci[bot]]

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/709#issuecomment-2197298810): >/override ci/prow/security Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

[openshift-ci[bot]]

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	7d8fdddcc1d9334c47d4096e6950d028eda99f8b	link	true	/test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[huangmingxia]

Verified pass with registry.build03.ci.openshift.org/ci-ln-slfhyqk/release:latest on version 4.15.

[hmx@fedora ~]$ oc get clusterversion
NAME      VERSION                                                   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.15.0-0.ci.test-2024-07-01-031220-ci-ln-slfhyqk-latest   True        False         50m     Cluster version is 4.15.0-0.ci.test-2024-07-01-031220-ci-ln-slfhyqk-latest

[hmx@fedora ~]$  oc -n openshift-cloud-credential-operator get -o json credentialsrequests | jq -r '.items[] | select(tostring | contains("InfrastructureMismatch") | not) | .metadata.name as $n | .status.conditions // [{type: "NoConditions"}] | .[] | .type + "=" + .status + " " + $n + " " + .reason + ": " + .message' | sort
NoConditions= aws-ebs-csi-driver-operator : 
NoConditions= cloud-credential-operator-iam-ro : 
NoConditions= openshift-cloud-network-config-controller-aws : 
NoConditions= openshift-image-registry : 
NoConditions= openshift-ingress : 
NoConditions= openshift-machine-api-aws : 

[hmx@fedora ~]$ oc get pod -n openshift-cloud-credential-operator 
NAME                                         READY   STATUS    RESTARTS   AGE
cloud-credential-operator-8544487899-nx5sw   2/2     Running   0          73m
pod-identity-webhook-b78f584db-bfbrb         1/1     Running   0          70m
pod-identity-webhook-b78f584db-q8d6l         1/1     Running   0          70m

[hmx@fedora ~]$ oc logs cloud-credential-operator-8544487899-nx5sw -n openshift-cloud-credential-operator -c cloud-credential-operator > cloud-credential-operator-8544487899-nx5sw.log
[hmx@fedora ~]$ grep "an empty awsSTSIAMRoleARN was found" cloud-credential-operator-8544487899-nx5sw.log
[hmx@fedora ~]$ 

[jstuever]

/jira refresh

[openshift-ci-robot]

@jstuever: This pull request references Jira Issue OCPBUGS-36291, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.15.z) matches configured target version for branch (4.15.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-34117](https://issues.redhat.com//browse/OCPBUGS-34117) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-34117](https://issues.redhat.com//browse/OCPBUGS-34117) targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z * bug has dependents

Requesting review from QA contact: /cc @huangmingxia

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/709#issuecomment-2200612852): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[huangmingxia]

/cherry-pick-approved

[huangmingxia]

/label cherry-pick-approved

[openshift-ci-robot]

@openshift-cherrypick-robot: Jira Issue OCPBUGS-36291: All pull requests linked via external trackers have merged:

• openshift/cloud-credential-operator#709

Jira Issue OCPBUGS-36291 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/709): >This is an automated cherry-pick of #704 > >/assign wking > >/cherrypick release-4.14 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

[openshift-cherrypick-robot]

@openshift-cherrypick-robot: new pull request created: #713

In response to [this](): >This is an automated cherry-pick of #704 > >/assign wking > >/cherrypick release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cloud-credential-operator-container-v4.15.0-202407090908.p0.g0429db3.assembly.stream.el8 for distgit ose-cloud-credential-operator. All builds following this will include this PR.

[openshift-merge-robot]

Fix included in accepted release 4.15.0-0.nightly-2024-07-09-152133