search

openshift / cloud-credential-operator

Manage cloud provider credentials as Kubernetes CRDs
Apache License 2.0
62 stars 145 forks source link

[release-4.14] OCPBUGS-36716: AWS STS should not error when a credentailsRequest does not have awsSTSIAMRoleARN #713

Closed openshift-cherrypick-robot closed 3 months ago

openshift-cherrypick-robot commented 3 months ago

This is an automated cherry-pick of #709

/assign openshift-cherrypick-robot

openshift-ci-robot commented 3 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-36291 has been cloned as Jira Issue OCPBUGS-36716. Will retitle bug to link to clone. /retitle [release-4.14] OCPBUGS-36716: AWS STS should not error when a credentailsRequest does not have awsSTSIAMRoleARN

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/713): >This is an automated cherry-pick of #709 > >/assign openshift-cherrypick-robot Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-36716, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/713): >This is an automated cherry-pick of #709 > >/assign openshift-cherrypick-robot Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 48.35%. Comparing base (67fe51e) to head (a5fbea6).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/713/graphs/tree.svg?width=650&height=150&src=pr&token=MSJhsyXrnA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/713?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## release-4.14 #713 +/- ## ============================================= Coverage 48.35% 48.35% ============================================= Files 96 96 Lines 11760 11758 -2 ============================================= Hits 5686 5686 + Misses 5441 5439 -2 Partials 633 633 ``` | [Files](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/713?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [pkg/aws/actuator/actuator.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/713?src=pr&el=tree&filepath=pkg%2Faws%2Factuator%2Factuator.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2F3cy9hY3R1YXRvci9hY3R1YXRvci5nbw==) | `64.06% <50.00%> (+0.15%)` | :arrow_up: |
huangmingxia commented 3 months ago

/retest

wking commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@wking: This pull request references Jira Issue OCPBUGS-36716, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.z) matches configured target version for branch (4.14.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-36291](https://issues.redhat.com//browse/OCPBUGS-36291) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-36291](https://issues.redhat.com//browse/OCPBUGS-36291) targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z * bug has dependents

Requesting review from QA contact: /cc @jianping-shu

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/713#issuecomment-2219523785): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
huangmingxia commented 3 months ago

/retest

jstuever commented 3 months ago

/lgtm /approve /label backport-risk-assessed

jstuever commented 3 months ago

/override ci/prow/security

jstuever commented 3 months ago

/assign

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cloud-credential-operator/blob/release-4.14/OWNERS)~~ [jstuever] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 3 months ago

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/713#issuecomment-2221111920): >/override ci/prow/security Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 months ago

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security a5fbea600587227eeb9647c7e3f342fcda89aa84 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
huangmingxia commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@huangmingxia: This pull request references Jira Issue OCPBUGS-36716, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.z) matches configured target version for branch (4.14.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-36291](https://issues.redhat.com//browse/OCPBUGS-36291) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-36291](https://issues.redhat.com//browse/OCPBUGS-36291) targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z * bug has dependents

Requesting review from QA contact: /cc @huangmingxia

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/713#issuecomment-2221943013): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
huangmingxia commented 3 months ago

Verified pass with registry.build03.ci.openshift.org/ci-ln-1tzjc82/release:latest on version 4.14.

[hmx@fedora openshift-tests-private]$ oc get clusterversion
NAME      VERSION                                                   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.14.0-0.ci.test-2024-07-11-024425-ci-ln-1tzjc82-latest   True        False         17m     Cluster version is 4.14.0-0.ci.test-2024-07-11-024425-ci-ln-1tzjc82-latest
[hmx@fedora openshift-tests-private]$ oc -n openshift-cloud-credential-operator get -o json credentialsrequests | jq -r '.items[] | select(tostring | contains("InfrastructureMismatch") | not) | .metadata.name as $n | .status.conditions // [{type: "NoConditions"}] | .[] | .type + "=" + .status + " " + $n + " " + .reason + ": " + .message' | sort
NoConditions= aws-ebs-csi-driver-operator : 
NoConditions= cloud-credential-operator-iam-ro : 
NoConditions= openshift-cloud-network-config-controller-aws : 
NoConditions= openshift-image-registry : 
NoConditions= openshift-ingress : 
NoConditions= openshift-machine-api-aws : 

[hmx@fedora openshift-tests-private]$ oc get pods -n openshift-cloud-credential-operator
NAME                                        READY   STATUS    RESTARTS   AGE
cloud-credential-operator-c7446fddb-kq9b6   2/2     Running   0          34m
pod-identity-webhook-77bf654f9-69kq7        1/1     Running   0          26m
pod-identity-webhook-77bf654f9-r77sc        1/1     Running   0          26m

[hmx@fedora openshift-tests-private]$ oc logs cloud-credential-operator-c7446fddb-kq9b6 -n openshift-cloud-credential-operator -c cloud-credential-operator | grep "an empty awsSTSIAMRoleARN was found"
[hmx@fedora openshift-tests-private]$
huangmingxia commented 3 months ago

/label cherry-pick-approved

openshift-ci-robot commented 3 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-36716: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36716 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/713): >This is an automated cherry-pick of #709 > >/assign openshift-cherrypick-robot Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cloud-credential-operator-container-v4.14.0-202407110439.p0.g566e7f6.assembly.stream.el8 for distgit ose-cloud-credential-operator. All builds following this will include this PR.