search

openshift / cloud-credential-operator

Manage cloud provider credentials as Kubernetes CRDs
Apache License 2.0
62 stars 143 forks source link

[release-4.16] OCPBUGS-36834: GCP passthrough permissions check to ignore problematic permissions. #714

Closed openshift-cherrypick-robot closed 1 month ago

openshift-cherrypick-robot commented 2 months ago

This is an automated cherry-pick of #712

/assign jstuever

/cherrypick release-4.15 release-4.14

openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-36140 has been cloned as Jira Issue OCPBUGS-36834. Will retitle bug to link to clone. /retitle [release-4.16] OCPBUGS-36834: GCP passthrough permissions check to ignore problematic permissions.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/714): >This is an automated cherry-pick of #712 > >/assign jstuever > >/cherrypick release-4.15 release-4.14 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-36834, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/714): >This is an automated cherry-pick of #712 > >/assign jstuever > >/cherrypick release-4.15 release-4.14 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 48.33%. Comparing base (c6c1b0b) to head (d5f2dfe). Report is 4 commits behind head on release-4.16.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/714/graphs/tree.svg?width=650&height=150&src=pr&token=MSJhsyXrnA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/714?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## release-4.16 #714 +/- ## ================================================ - Coverage 48.35% 48.33% -0.02% ================================================ Files 96 96 Lines 11797 11801 +4 ================================================ Hits 5704 5704 - Misses 5460 5464 +4 Partials 633 633 ``` | [Files](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/714?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [pkg/operator/utils/gcp/utils.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/714?src=pr&el=tree&filepath=pkg%2Foperator%2Futils%2Fgcp%2Futils.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL29wZXJhdG9yL3V0aWxzL2djcC91dGlscy5nbw==) | `69.89% <0.00%> (-3.15%)` | :arrow_down: |
jstuever commented 2 months ago

/lgtm /approve /label backport-risk-assessed

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cloud-credential-operator/blob/release-4.16/OWNERS)~~ [jstuever] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jstuever commented 2 months ago

/override ci/prow/security These issues is not directly related to this PR, and there are bugs already open to address them.

openshift-ci[bot] commented 2 months ago

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/714#issuecomment-2221589975): >/override ci/prow/security >These issues is not directly related to this PR, and there are bugs already open to address them. > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jstuever commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@jstuever: This pull request references Jira Issue OCPBUGS-36834, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/714#issuecomment-2229046973): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jstuever commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@jstuever: This pull request references Jira Issue OCPBUGS-36834, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-36140](https://issues.redhat.com//browse/OCPBUGS-36140) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-36140](https://issues.redhat.com//browse/OCPBUGS-36140) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @jianping-shu

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/714#issuecomment-2229059612): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jianping-shu commented 1 month ago

Verified with cluster-bot build 4.16.0-0.ci.test-2024-07-18-114458-ci-ln-p82dwd2-latest. The GCP cluster with Passthrough mode installed successfully and healthy. The GCP cluster with default mode (i.e. Mint) installed successfully and healthy.

jianping-shu commented 1 month ago

/label cherry-pick-approved

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD fffc75d5574777fb7f0577562148b477ebd63359 and 2 for PR HEAD d5f2dfe39721f4856b7b619fdc251b09d7b6c77c in total

jstuever commented 1 month ago

/retest-required

jstuever commented 1 month ago

/override ci/prow/security

openshift-ci[bot] commented 1 month ago

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/714#issuecomment-2237749178): >/override ci/prow/security Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD f1f67eb027af239a5843ad13ffcacb6f9b7321d8 and 1 for PR HEAD d5f2dfe39721f4856b7b619fdc251b09d7b6c77c in total

jstuever commented 1 month ago

/test ci/prow/security

openshift-ci[bot] commented 1 month ago

@jstuever: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/714#issuecomment-2237788221): >/test ci/prow/security Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jstuever commented 1 month ago

/test security

jstuever commented 1 month ago

/override ci/prow/security This is being tracked in another bug.

openshift-ci[bot] commented 1 month ago

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/714#issuecomment-2237790568): >/override ci/prow/security >This is being tracked in another bug. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security d5f2dfe39721f4856b7b619fdc251b09d7b6c77c link true /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-36834: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36834 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/714): >This is an automated cherry-pick of #712 > >/assign jstuever > >/cherrypick release-4.15 release-4.14 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 1 month ago

@openshift-cherrypick-robot: new pull request created: #730

In response to [this](): >This is an automated cherry-pick of #712 > >/assign jstuever > >/cherrypick release-4.15 release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cloud-credential-operator-container-v4.16.0-202407190835.p0.g0fc6474.assembly.stream.el9 for distgit ose-cloud-credential-operator. All builds following this will include this PR.