search

openshift / cloud-credential-operator

Manage cloud provider credentials as Kubernetes CRDs
Apache License 2.0
62 stars 145 forks source link

OCPBUGS-35016: Update to azidentity v1.7.0 #716

Closed jstuever closed 3 months ago

jstuever commented 3 months ago

Update to azidentity v1.7.0

openshift-ci-robot commented 3 months ago

@jstuever: This pull request references Jira Issue OCPBUGS-35016, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @jianping-shu

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/716): >Update to azidentity v1.7.0 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.91%. Comparing base (ac30067) to head (47c9155). Report is 2 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/716/graphs/tree.svg?width=650&height=150&src=pr&token=MSJhsyXrnA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/716?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #716 +/- ## ========================================== - Coverage 48.33% 46.91% -1.42% ========================================== Files 96 102 +6 Lines 11801 12158 +357 ========================================== Hits 5704 5704 - Misses 5464 5821 +357 Partials 633 633 ``` [see 6 files with indirect coverage changes](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/716/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
jstuever commented 3 months ago

/test e2e-azure

jstuever commented 3 months ago

/test e2e-azure-manuail-oidc

openshift-ci[bot] commented 3 months ago

@jstuever: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/716#issuecomment-2226363696): >/test e2e-azure-manuail-oidc Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jstuever commented 3 months ago

/test e2e-azure-manual-oidc

jianping-shu commented 3 months ago

/retest

jianping-shu commented 3 months ago

Verified with cluster-bot build. jianpingshu@jshu-mac ~ % oc get clusterversion NAME VERSION AVAILABLE PROGRESSING SINCE STATUS version 4.17.0-0.ci.test-2024-07-15-013623-ci-ln-zrjt32t-latest True False 28m Cluster version is 4.17.0-0.ci.test-2024-07-15-013623-ci-ln-zrjt32t-latest Azure cluster with Microsoft Entra Workload ID installed successfully. Regression tested with OCP-50869/34470/66538/69971.

jstuever commented 3 months ago

/assign @dlom /label acknowledge-critical-fixes-only

dlom commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cloud-credential-operator/blob/master/OWNERS)~~ [dlom,jstuever] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 months ago

/retest-required

Remaining retests: 0 against base HEAD b2e88cc4dbcbf89a761a39c6c78221ee54cea5c1 and 2 for PR HEAD 47c91552e0f22fda833a44cdf79327f8b2abad1c in total

jstuever commented 3 months ago

/retest

jstuever commented 3 months ago

/retest

openshift-ci[bot] commented 3 months ago

@jstuever: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 3 months ago

@jstuever: Jira Issue OCPBUGS-35016: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-35016 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/716): >Update to azidentity v1.7.0 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cloud-credential-operator-container-v4.17.0-202407180110.p0.gc24c925.assembly.stream.el9 for distgit ose-cloud-credential-operator. All builds following this will include this PR.