search

openshift / cloud-credential-operator

Manage cloud provider credentials as Kubernetes CRDs
Apache License 2.0
62 stars 143 forks source link

OCPBUGS-36031: IBM/go-sdk-core update to v5.17.4 #718

Closed jstuever closed 2 months ago

jstuever commented 2 months ago

Update IBM/go-sdk-core to v5.17.4 in order to update hashicorp/go-retryablehttp to v0.7.7

openshift-ci-robot commented 2 months ago

@jstuever: This pull request references Jira Issue OCPBUGS-36031, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/718): >Update IBM/go-sdk-core to v5.6.3 in order to update hashicorp/go-retryablehttp to v0.7.7 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@jstuever: This pull request references Jira Issue OCPBUGS-36031, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/718): >Update IBM/go-sdk-core to v5.6.3 in order to update hashicorp/go-retryablehttp to v0.7.7 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jstuever commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@jstuever: This pull request references Jira Issue OCPBUGS-36031, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/718#issuecomment-2223969546): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jstuever commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@jstuever: This pull request references Jira Issue OCPBUGS-36031, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/718#issuecomment-2223972336): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jstuever commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@jstuever: This pull request references Jira Issue OCPBUGS-36031, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-36032](https://issues.redhat.com//browse/OCPBUGS-36032) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-36032](https://issues.redhat.com//browse/OCPBUGS-36032) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @jianping-shu

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/718#issuecomment-2223974080): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.36%. Comparing base (c6c1b0b) to head (7105a7b). Report is 2 commits behind head on release-4.16.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/718/graphs/tree.svg?width=650&height=150&src=pr&token=MSJhsyXrnA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/718?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## release-4.16 #718 +/- ## ================================================ + Coverage 48.35% 48.36% +0.01% ================================================ Files 96 96 Lines 11797 11812 +15 ================================================ + Hits 5704 5713 +9 - Misses 5460 5464 +4 - Partials 633 635 +2 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/718/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
jstuever commented 2 months ago

/override ci/prow/security This is being tracked in another Jira bug.

jstuever commented 2 months ago

/label backport-risk-assessed

jstuever commented 2 months ago

/assign @dlom

openshift-ci[bot] commented 2 months ago

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/718#issuecomment-2226346148): >/override ci/prow/security >This is being tracked in another Jira bug. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 months ago

@jstuever: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 7105a7b4b6a9e258a78e4a012f8a0b42dc050511 link true /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
dlom commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cloud-credential-operator/blob/release-4.16/OWNERS)~~ [dlom,jstuever] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jstuever commented 2 months ago

/assign @jianping-shu /unassign @dlom

jianping-shu commented 2 months ago

Verified with cluster-bot build. AWS STS cluster installed successfully and healthy. Regression tested OCP-36498/ 50869/48360/34470/64885. AWS cluster in Mint mode installed successfully and healthy. Regression tested OCP-36498/ 50869/48360/34470.

jianping-shu commented 2 months ago

/label cherry-pick-approved

openshift-ci-robot commented 2 months ago

@jstuever: Jira Issue OCPBUGS-36031: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36031 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/718): >Update IBM/go-sdk-core to v5.6.3 in order to update hashicorp/go-retryablehttp to v0.7.7 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-cloud-credential-operator-container-v4.16.0-202407142206.p0.gfffc75d.assembly.stream.el9 for distgit ose-cloud-credential-operator. All builds following this will include this PR.

openshift-ci-robot commented 2 months ago

@jstuever: Jira Issue OCPBUGS-36031 is in an unrecognized state (Verified) and will not be moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/718): >Update IBM/go-sdk-core to v5.17.4 in order to update hashicorp/go-retryablehttp to v0.7.7 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.