search

openshift / cloud-credential-operator

Manage cloud provider credentials as Kubernetes CRDs
Apache License 2.0
62 stars 145 forks source link

OCPBUGS-36028: IBM/go-sdk-core update to v5.17.4 #722

Closed jstuever closed 3 months ago

jstuever commented 3 months ago

Update IBM/go-sdk-core to v5.17.4 in order to update hashicorp/go-retryablehttp to v0.7.7

openshift-ci-robot commented 3 months ago

@jstuever: This pull request references Jira Issue OCPBUGS-36028, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/722): >Update IBM/go-sdk-core to v5.17.4 in order to update hashicorp/go-retryablehttp to v0.7.7 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.16%. Comparing base (15040f1) to head (7695913). Report is 1 commits behind head on release-4.13.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/722/graphs/tree.svg?width=650&height=150&src=pr&token=MSJhsyXrnA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/722?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## release-4.13 #722 +/- ## ============================================= Coverage 48.16% 48.16% ============================================= Files 94 94 Lines 10117 10117 ============================================= Hits 4873 4873 Misses 4663 4663 Partials 581 581 ```
jianping-shu commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@jianping-shu: This pull request references Jira Issue OCPBUGS-36028, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.13.z) matches configured target version for branch (4.13.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-36029](https://issues.redhat.com//browse/OCPBUGS-36029) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-36029](https://issues.redhat.com//browse/OCPBUGS-36029) targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z * bug has dependents

Requesting review from QA contact: /cc @jianping-shu

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/722#issuecomment-2238969198): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jianping-shu commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@jianping-shu: This pull request references Jira Issue OCPBUGS-36028, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.13.z) matches configured target version for branch (4.13.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-36029](https://issues.redhat.com//browse/OCPBUGS-36029) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-36029](https://issues.redhat.com//browse/OCPBUGS-36029) targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z * bug has dependents

Requesting review from QA contact: /cc @jianping-shu

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/722#issuecomment-2239202184): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jianping-shu commented 3 months ago

Verified with cluster-bot build 4.13.0-0.ci.test-2024-07-19-120535-ci-ln-8q74k12-latest. AWS STS cluster installed successfully and healthy. Regression tested OCP-36498/ 50869/48360/34470.

jianping-shu commented 3 months ago

/label cherry-pick-approved

jstuever commented 3 months ago

/override ci/prow/security There are other bugs to resolve this.

jstuever commented 3 months ago

/label backport-risk-assessed

jstuever commented 3 months ago

/assign @dlom

openshift-ci[bot] commented 3 months ago

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/722#issuecomment-2239582957): >/override ci/prow/security >There are other bugs to resolve this. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 months ago

@jstuever: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
dlom commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cloud-credential-operator/blob/release-4.13/OWNERS)~~ [dlom,jstuever] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 months ago

@jstuever: Jira Issue OCPBUGS-36028: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36028 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/722): >Update IBM/go-sdk-core to v5.17.4 in order to update hashicorp/go-retryablehttp to v0.7.7 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cloud-credential-operator This PR has been included in build ose-cloud-credential-operator-container-v4.13.0-202407192107.p0.g73ecd48.assembly.stream.el8. All builds following this will include this PR.

openshift-merge-robot commented 3 months ago

Fix included in accepted release 4.13.0-0.nightly-2024-07-19-230633