openshift / cloud-credential-operator

Manage cloud provider credentials as Kubernetes CRDs
Apache License 2.0
62 stars 143 forks source link

OCPBUGS-36027: IBM/go-sdk-core update to v5.17.4 #723

Closed jstuever closed 1 month ago

jstuever commented 2 months ago

Update IBM/go-sdk-core to v5.17.4 in order to update hashicorp/go-retryablehttp to v0.7.7

openshift-ci-robot commented 2 months ago

@jstuever: This pull request references Jira Issue OCPBUGS-36027, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/723): >Update IBM/go-sdk-core to v5.17.4 in order to update hashicorp/go-retryablehttp to v0.7.7 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.62%. Comparing base (54058b5) to head (2e48a2d).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/723/graphs/tree.svg?width=650&height=150&src=pr&token=MSJhsyXrnA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/723?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## release-4.12 #723 +/- ## ============================================= Coverage 46.62% 46.62% ============================================= Files 94 94 Lines 10053 10053 ============================================= Hits 4687 4687 Misses 4807 4807 Partials 559 559 ```
jstuever commented 1 month ago

/label backport-risk-assessed

jstuever commented 1 month ago

/assign @dlom

jstuever commented 1 month ago

/override ci/prow/security These issues are being tracked in other bugs.

openshift-ci[bot] commented 1 month ago

@jstuever: jstuever unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/723#issuecomment-2239811370): >/override ci/prow/security >These issues are being tracked in other bugs. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dlom commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cloud-credential-operator/blob/release-4.12/OWNERS)~~ [dlom] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
huangmingxia commented 1 month ago

/retest

jstuever commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@jstuever: This pull request references Jira Issue OCPBUGS-36027, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.12.z) matches configured target version for branch (4.12.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-36028](https://issues.redhat.com//browse/OCPBUGS-36028) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-36028](https://issues.redhat.com//browse/OCPBUGS-36028) targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z * bug has dependents

Requesting review from QA contact: /cc @huangmingxia

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/723#issuecomment-2243767092): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jstuever commented 1 month ago

/override ci/prow/security These are to be handled elsewhere.

openshift-ci[bot] commented 1 month ago

@jstuever: jstuever unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/723#issuecomment-2243772111): >/override ci/prow/security >These are to be handled elsewhere. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
dlom commented 1 month ago

/override ci/prow/security

openshift-ci[bot] commented 1 month ago

@dlom: Overrode contexts on behalf of dlom: ci/prow/security

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/723#issuecomment-2248701260): >/override ci/prow/security Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

@jstuever: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jstuever commented 1 month ago

/assign @huangmingxia

jianping-shu commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@jianping-shu: This pull request references Jira Issue OCPBUGS-36027, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.12.z) matches configured target version for branch (4.12.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-36028](https://issues.redhat.com//browse/OCPBUGS-36028) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-36028](https://issues.redhat.com//browse/OCPBUGS-36028) targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z * bug has dependents

Requesting review from QA contact: /cc @jianping-shu

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/723#issuecomment-2255036464): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jianping-shu commented 1 month ago

Verified with cluster-bot build 4.12.0-0.ci.test-2024-07-29-063447-ci-ln-ctxswlk-latest. AWS STS cluster installed successfully and healthy. Regression tested OCP-36498/ 50869/48360/34470.

jianping-shu commented 1 month ago

/label cherry-pick-approved

openshift-ci-robot commented 1 month ago

@jstuever: Jira Issue OCPBUGS-36027: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36027 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/723): >Update IBM/go-sdk-core to v5.17.4 in order to update hashicorp/go-retryablehttp to v0.7.7 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cloud-credential-operator This PR has been included in build ose-cloud-credential-operator-container-v4.12.0-202407290902.p0.gf0d5f99.assembly.stream.el8. All builds following this will include this PR.

openshift-merge-robot commented 1 month ago

Fix included in accepted release 4.12.0-0.nightly-2024-07-29-093516