search

openshift / cloud-credential-operator

Manage cloud provider credentials as Kubernetes CRDs
Apache License 2.0
62 stars 143 forks source link

pkg/gcp: check error when building client #724

Open patrickdillon opened 2 months ago

patrickdillon commented 2 months ago

Fixes an unchecked error when building the GCP client.

patrickdillon commented 2 months ago

I'm primarily using this to build a release image to help with debugging.

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 46.90%. Comparing base (ac30067) to head (e0971da). Report is 4 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/724/graphs/tree.svg?width=650&height=150&src=pr&token=MSJhsyXrnA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/724?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #724 +/- ## ========================================== - Coverage 48.33% 46.90% -1.43% ========================================== Files 96 102 +6 Lines 11801 12160 +359 ========================================== Hits 5704 5704 - Misses 5464 5822 +358 - Partials 633 634 +1 ``` | [Files](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/724?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [pkg/gcp/actuator/actuator.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/724?src=pr&el=tree&filepath=pkg%2Fgcp%2Factuator%2Factuator.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2djcC9hY3R1YXRvci9hY3R1YXRvci5nbw==) | `56.75% <0.00%> (-0.24%)` | :arrow_down: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/724/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cloud-credential-operator/blob/master/OWNERS)~~ [jstuever] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jstuever commented 1 month ago

/override ci/prow/security This is being tracked and fixed elsewhere.

openshift-ci[bot] commented 1 month ago

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/724#issuecomment-2229608131): >/override ci/prow/security >This is being tracked and fixed elsewhere. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

New changes are detected. LGTM label has been removed.

patrickdillon commented 1 month ago

/lgtm /approve

oh thanks! I pushed a commit before checking github and stomped on this. I would have created a bug and merged it had I noticed.

I should have marked this wip /wip

openshift-ci[bot] commented 1 month ago

@patrickdillon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security e0971da51d42ca68e70a4b68bf36e8e154d6fbec link true /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
patrickdillon commented 1 month ago

/hold

openshift-merge-robot commented 1 month ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jstuever commented 1 month ago

/unassign