openshift / cloud-credential-operator

Manage cloud provider credentials as Kubernetes CRDs
Apache License 2.0
62 stars 143 forks source link

CCO-580: Upgrade to Kubernetes 1.30 #725

Closed jstuever closed 1 month ago

jstuever commented 1 month ago

This change upgrades the dependencies to Kubernetes 1.30. This requires a controller-runtime update to be compatible with the newer client-go.

openshift-ci-robot commented 1 month ago

@jstuever: This pull request references CCO-541 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/725): >This change upgrades the dependencies to Kubernetes 1.30. This requires a controller-runtime update to be compatible with the newer client-go. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jstuever commented 1 month ago

/retitle CCO-580: Upgrade to Kubernetes 1.30

openshift-ci-robot commented 1 month ago

@jstuever: This pull request references CCO-580 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/725): >This change upgrades the dependencies to Kubernetes 1.30. This requires a controller-runtime update to be compatible with the newer client-go. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jstuever commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@jstuever: This pull request references CCO-580 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/725#issuecomment-2229514387): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jstuever commented 1 month ago

/retest

jstuever commented 1 month ago

Depends on https://github.com/openshift/cloud-credential-operator/pull/719

jstuever commented 1 month ago

/retest

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 154 lines in your changes missing coverage. Please review.

Project coverage is 46.76%. Comparing base (c24c925) to head (8271c24). Report is 2 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/725/graphs/tree.svg?width=650&height=150&src=pr&token=MSJhsyXrnA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/725?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #725 +/- ## ========================================== - Coverage 46.91% 46.76% -0.16% ========================================== Files 102 102 Lines 12158 12197 +39 ========================================== Hits 5704 5704 - Misses 5821 5860 +39 Partials 633 633 ``` | [Files](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/725?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [pkg/operator/loglevel/controller.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/725?src=pr&el=tree&filepath=pkg%2Foperator%2Floglevel%2Fcontroller.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL29wZXJhdG9yL2xvZ2xldmVsL2NvbnRyb2xsZXIuZ28=) | `49.15% <0.00%> (ø)` | | | [pkg/cmd/operator/cmd.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/725?src=pr&el=tree&filepath=pkg%2Fcmd%2Foperator%2Fcmd.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2NtZC9vcGVyYXRvci9jbWQuZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/operator/secretannotator/aws/reconciler.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/725?src=pr&el=tree&filepath=pkg%2Foperator%2Fsecretannotator%2Faws%2Freconciler.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL29wZXJhdG9yL3NlY3JldGFubm90YXRvci9hd3MvcmVjb25jaWxlci5nbw==) | `44.91% <0.00%> (ø)` | | | [pkg/operator/secretannotator/azure/reconciler.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/725?src=pr&el=tree&filepath=pkg%2Foperator%2Fsecretannotator%2Fazure%2Freconciler.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL29wZXJhdG9yL3NlY3JldGFubm90YXRvci9henVyZS9yZWNvbmNpbGVyLmdv) | `35.52% <0.00%> (ø)` | | | [pkg/operator/secretannotator/gcp/reconciler.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/725?src=pr&el=tree&filepath=pkg%2Foperator%2Fsecretannotator%2Fgcp%2Freconciler.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL29wZXJhdG9yL3NlY3JldGFubm90YXRvci9nY3AvcmVjb25jaWxlci5nbw==) | `45.28% <0.00%> (ø)` | | | [...g/operator/secretannotator/openstack/reconciler.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/725?src=pr&el=tree&filepath=pkg%2Foperator%2Fsecretannotator%2Fopenstack%2Freconciler.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL29wZXJhdG9yL3NlY3JldGFubm90YXRvci9vcGVuc3RhY2svcmVjb25jaWxlci5nbw==) | `55.11% <0.00%> (ø)` | | | [pkg/operator/secretannotator/vsphere/reconciler.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/725?src=pr&el=tree&filepath=pkg%2Foperator%2Fsecretannotator%2Fvsphere%2Freconciler.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL29wZXJhdG9yL3NlY3JldGFubm90YXRvci92c3BoZXJlL3JlY29uY2lsZXIuZ28=) | `37.17% <0.00%> (ø)` | | | [pkg/operator/cleanup/cleanup\_controller.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/725?src=pr&el=tree&filepath=pkg%2Foperator%2Fcleanup%2Fcleanup_controller.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL29wZXJhdG9yL2NsZWFudXAvY2xlYW51cF9jb250cm9sbGVyLmdv) | `52.32% <0.00%> (ø)` | | | [pkg/operator/secretannotator/utils/utils.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/725?src=pr&el=tree&filepath=pkg%2Foperator%2Fsecretannotator%2Futils%2Futils.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL29wZXJhdG9yL3NlY3JldGFubm90YXRvci91dGlscy91dGlscy5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/operator/status/status\_controller.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/725?src=pr&el=tree&filepath=pkg%2Foperator%2Fstatus%2Fstatus_controller.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL29wZXJhdG9yL3N0YXR1cy9zdGF0dXNfY29udHJvbGxlci5nbw==) | `51.56% <0.00%> (ø)` | | | ... and [2 more](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/725?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | |
dlom commented 1 month ago

@jstuever here's how I got code generation/verify working again in hive: https://github.com/dlom/hive/commit/b9e81e1bd3c77f89e7b875db76f1c7b6e6bfdb96

jstuever commented 1 month ago

/retest

jstuever commented 1 month ago

/retest

jstuever commented 1 month ago

/retest

jstuever commented 1 month ago

/assign @dlom

jstuever commented 1 month ago

/retest

jstuever commented 1 month ago

/retest-required

jstuever commented 1 month ago

/retest

openshift-ci[bot] commented 1 month ago

@jstuever: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
dlom commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cloud-credential-operator/blob/master/OWNERS)~~ [dlom,jstuever] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cloud-credential-operator This PR has been included in build ose-cloud-credential-operator-container-v4.17.0-202407300147.p0.ga7f311b.assembly.stream.el9. All builds following this will include this PR.