search

openshift / cloud-credential-operator

Manage cloud provider credentials as Kubernetes CRDs
Apache License 2.0
62 stars 143 forks source link

WIP: CCO-579: new ccoctl azure flag to enable selection of cloud environment #726

Open jstuever opened 1 month ago

jstuever commented 1 month ago

Add a new --cloud flag to the ccoctl azure subcommand to enable selection of the cloud environment. The options are AzureChina, AzureGovernment, and AzurePublic. If left empty, the default will be selected from azidenity.

openshift-ci-robot commented 1 month ago

@jstuever: This pull request references CCO-579 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/726): >Add a new --cloud flag to the ccoctl azure subcommand to enable selection of the cloud environment. The options are AzureChina, AzureGovernment, and AzurePublic. If left empty, the default will be selected from azidenity. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cloud-credential-operator/blob/master/OWNERS)~~ [jstuever] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 62 lines in your changes missing coverage. Please review.

Project coverage is 46.69%. Comparing base (c24c925) to head (3373f98). Report is 6 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/726/graphs/tree.svg?width=650&height=150&src=pr&token=MSJhsyXrnA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/726?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #726 +/- ## ========================================== - Coverage 46.91% 46.69% -0.23% ========================================== Files 102 102 Lines 12158 12216 +58 ========================================== Hits 5704 5704 - Misses 5821 5879 +58 Partials 633 633 ``` | [Files](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/726?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [pkg/cmd/provisioning/azure/azure.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/726?src=pr&el=tree&filepath=pkg%2Fcmd%2Fprovisioning%2Fazure%2Fazure.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2NtZC9wcm92aXNpb25pbmcvYXp1cmUvYXp1cmUuZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/cmd/provisioning/azure/create\_all.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/726?src=pr&el=tree&filepath=pkg%2Fcmd%2Fprovisioning%2Fazure%2Fcreate_all.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2NtZC9wcm92aXNpb25pbmcvYXp1cmUvY3JlYXRlX2FsbC5nbw==) | `0.00% <0.00%> (ø)` | | | [...md/provisioning/azure/create\_managed\_identities.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/726?src=pr&el=tree&filepath=pkg%2Fcmd%2Fprovisioning%2Fazure%2Fcreate_managed_identities.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2NtZC9wcm92aXNpb25pbmcvYXp1cmUvY3JlYXRlX21hbmFnZWRfaWRlbnRpdGllcy5nbw==) | `56.28% <0.00%> (-1.43%)` | :arrow_down: | | [pkg/cmd/provisioning/azure/create\_oidc\_issuer.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/726?src=pr&el=tree&filepath=pkg%2Fcmd%2Fprovisioning%2Fazure%2Fcreate_oidc_issuer.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2NtZC9wcm92aXNpb25pbmcvYXp1cmUvY3JlYXRlX29pZGNfaXNzdWVyLmdv) | `51.62% <0.00%> (-1.74%)` | :arrow_down: | | [pkg/cmd/provisioning/azure/delete.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/726?src=pr&el=tree&filepath=pkg%2Fcmd%2Fprovisioning%2Fazure%2Fdelete.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2NtZC9wcm92aXNpb25pbmcvYXp1cmUvZGVsZXRlLmdv) | `0.00% <0.00%> (ø)` | |
jstuever commented 1 month ago

/test ci/prow/security

openshift-ci[bot] commented 1 month ago

@jstuever: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/726#issuecomment-2234358848): >/test ci/prow/security Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jstuever commented 1 month ago

/test e2e-azure-manual-oidc

jstuever commented 1 month ago

/retest

jstuever commented 1 month ago

/retest

jstuever commented 1 month ago

/retest

openshift-ci[bot] commented 1 month ago

@jstuever: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jstuever commented 1 month ago

/assign @jianping-shu Is this something you can test?