openshift / cloud-credential-operator

Manage cloud provider credentials as Kubernetes CRDs
Apache License 2.0
62 stars 145 forks source link

OCPBUGS-37277: Update to cloud.google.com/go/storage v1.43.0 #729

Closed jstuever closed 2 months ago

openshift-ci-robot commented 3 months ago

@jstuever: This pull request references Jira Issue OCPBUGS-37277, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/729): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jstuever commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@jstuever: This pull request references Jira Issue OCPBUGS-37277, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/729#issuecomment-2237771424): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.34%. Comparing base (46a358b) to head (bce5341). Report is 4 commits behind head on release-4.15.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/729/graphs/tree.svg?width=650&height=150&src=pr&token=MSJhsyXrnA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/729?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## release-4.15 #729 +/- ## ================================================ + Coverage 48.33% 48.34% +0.01% ================================================ Files 96 96 Lines 11798 11813 +15 ================================================ + Hits 5702 5711 +9 - Misses 5462 5466 +4 - Partials 634 636 +2 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/729/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
jstuever commented 3 months ago

/retest

jstuever commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@jstuever: This pull request references Jira Issue OCPBUGS-37277, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.z) matches configured target version for branch (4.15.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-30478](https://issues.redhat.com//browse/OCPBUGS-30478) is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-30478](https://issues.redhat.com//browse/OCPBUGS-30478) targets the "4.16.0" version, which is one of the valid target versions: 4.16.0, 4.16.z * bug has dependents

Requesting review from QA contact: /cc @jianping-shu

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/729#issuecomment-2239617447): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jstuever commented 3 months ago

/assign @dlom

jstuever commented 3 months ago

/label backport-risk-assessed

jstuever commented 3 months ago

/hold For https://github.com/openshift/cloud-credential-operator/pull/728, will probably need rebase after.

dlom commented 3 months ago

/lgtm

jstuever commented 3 months ago

/retest

jstuever commented 3 months ago

/override ci/prow/security This issue is being addressed by another existing Jira bug.

openshift-ci[bot] commented 3 months ago

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/729#issuecomment-2261187664): >/override ci/prow/security >This issue is being addressed by another existing Jira bug. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jstuever commented 3 months ago

/hold cancel

dlom commented 3 months ago

/lgtm

dlom commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cloud-credential-operator/blob/release-4.15/OWNERS)~~ [dlom,jstuever] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jianping-shu commented 2 months ago

Verified with cluster-bot build 4.15.0-0.ci.test-2024-08-01-091223-ci-ln-2v5wi9k-latest. The GCP cluster with default mode (i.e. Mint) installed successfully and healthy. Regression tested with OCP-34470/45975/50869.

jianping-shu commented 2 months ago

/label cherry-pick-approved

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 2d82b0740e03a017618fc80e431b3f83c55b037d and 2 for PR HEAD bce534163fb48ecd26461399f5f894a8285f429e in total

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 030ae923aaae2ff7b0a1eb5d9e97c460194ca7e8 and 1 for PR HEAD bce534163fb48ecd26461399f5f894a8285f429e in total

jstuever commented 2 months ago

/override ci/prow/security This is being handled by another existing Jira bug.

openshift-ci[bot] commented 2 months ago

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/729#issuecomment-2263607804): >/override ci/prow/security >This is being handled by another existing Jira bug. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 months ago

@jstuever: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-manual-oidc 1b3b93f4425734c80e6ffc23f647d86201e5c5fe link false /test e2e-gcp-manual-oidc
ci/prow/e2e-azure-manual-oidc 1b3b93f4425734c80e6ffc23f647d86201e5c5fe link true /test e2e-azure-manual-oidc
ci/prow/security bce534163fb48ecd26461399f5f894a8285f429e link true /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 months ago

@jstuever: Jira Issue OCPBUGS-37277: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-37277 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/729): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cloud-credential-operator This PR has been included in build ose-cloud-credential-operator-container-v4.15.0-202408011842.p0.gbf4b487.assembly.stream.el8. All builds following this will include this PR.