search

openshift / cloud-credential-operator

Manage cloud provider credentials as Kubernetes CRDs
Apache License 2.0
62 stars 145 forks source link

[release-4.15] OCPBUGS-37461: Set required-scc for openshift workloads #736

Closed kramaranya closed 2 months ago

kramaranya commented 3 months ago

OCPBUGS-37461

Cherry-pick of #681

openshift-ci-robot commented 3 months ago

@kramaranya: This pull request references Jira Issue OCPBUGS-37461, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/736): >[OCPBUGS-37461](https://issues.redhat.com/browse/OCPBUGS-37461) > >Cherry-pick of #681 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
kramaranya commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@kramaranya: This pull request references Jira Issue OCPBUGS-37461, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.z) matches configured target version for branch (4.15.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-35007](https://issues.redhat.com//browse/OCPBUGS-35007) is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-35007](https://issues.redhat.com//browse/OCPBUGS-35007) targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z * bug has dependents

Requesting review from QA contact: /cc @jianping-shu

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/736#issuecomment-2245261424): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.34%. Comparing base (f8455ca) to head (c8a1f8c). Report is 8 commits behind head on release-4.15.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/736/graphs/tree.svg?width=650&height=150&src=pr&token=MSJhsyXrnA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/736?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## release-4.15 #736 +/- ## ================================================ + Coverage 48.33% 48.34% +0.01% ================================================ Files 96 96 Lines 11798 11813 +15 ================================================ + Hits 5702 5711 +9 - Misses 5462 5466 +4 - Partials 634 636 +2 ``` | [Files](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/736?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [pkg/assets/v410\_00\_assets/bindata.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/736?src=pr&el=tree&filepath=pkg%2Fassets%2Fv410_00_assets%2Fbindata.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2Fzc2V0cy92NDEwXzAwX2Fzc2V0cy9iaW5kYXRhLmdv) | `46.96% <ø> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/736/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
kramaranya commented 3 months ago

/retest-required

kramaranya commented 3 months ago

/retest-required

jstuever commented 3 months ago

/retest

huangmingxia commented 2 months ago

/retest

huangmingxia commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@huangmingxia: This pull request references Jira Issue OCPBUGS-37461, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.z) matches configured target version for branch (4.15.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-35007](https://issues.redhat.com//browse/OCPBUGS-35007) is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-35007](https://issues.redhat.com//browse/OCPBUGS-35007) targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z * bug has dependents

Requesting review from QA contact: /cc @huangmingxia

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/736#issuecomment-2274825109): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jstuever commented 2 months ago

/lgtm /approve /label backport-risk-assessed

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jstuever, kramaranya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cloud-credential-operator/blob/release-4.15/OWNERS)~~ [jstuever] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jstuever commented 2 months ago

/override ci/prow/security This is being addressed in another existing Jira big.

openshift-ci[bot] commented 2 months ago

@jstuever: Overrode contexts on behalf of jstuever: ci/prow/security

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/736#issuecomment-2276754377): >/override ci/prow/security >This is being addressed in another existing Jira big. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
huangmingxia commented 2 months ago

/label cherry-pick-approved

Verified pass with image registry.build05.ci.openshift.org/ci-ln-hxxlz2b/release:latest on 4.15 with below cluster type.

openshift-ci[bot] commented 2 months ago

@kramaranya: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 months ago

@kramaranya: Jira Issue OCPBUGS-37461: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-37461 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/736): >[OCPBUGS-37461](https://issues.redhat.com/browse/OCPBUGS-37461) > >Cherry-pick of #681 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cloud-credential-operator This PR has been included in build ose-cloud-credential-operator-container-v4.15.0-202408091808.p0.g05c0310.assembly.stream.el8. All builds following this will include this PR.

openshift-merge-robot commented 2 months ago

Fix included in accepted release 4.15.0-0.nightly-2024-08-10-090823