search

openshift / cloud-credential-operator

Manage cloud provider credentials as Kubernetes CRDs
Apache License 2.0
62 stars 145 forks source link

SPLAT-1718: Remove alibaba #737

Closed jcpowermac closed 2 months ago

jcpowermac commented 3 months ago

will rewrite the commit history after all tests pass

jcpowermac commented 3 months ago

/hold

openshift-ci-robot commented 3 months ago

@jcpowermac: This pull request references SPLAT-1718 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/737): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jcpowermac commented 3 months ago

/retest

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 48.16%. Comparing base (a7f311b) to head (1b38598). Report is 2 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/737/graphs/tree.svg?width=650&height=150&src=pr&token=MSJhsyXrnA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/737?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #737 +/- ## ========================================== + Coverage 46.76% 48.16% +1.39% ========================================== Files 102 96 -6 Lines 12197 11909 -288 ========================================== + Hits 5704 5736 +32 + Misses 5860 5548 -312 + Partials 633 625 -8 ``` | [Files](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/737?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [cmd/ccoctl/main.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/737?src=pr&el=tree&filepath=cmd%2Fccoctl%2Fmain.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-Y21kL2Njb2N0bC9tYWluLmdv) | `0.00% <ø> (ø)` | | | [pkg/apis/cloudcredential/v1/register.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/737?src=pr&el=tree&filepath=pkg%2Fapis%2Fcloudcredential%2Fv1%2Fregister.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2FwaXMvY2xvdWRjcmVkZW50aWFsL3YxL3JlZ2lzdGVyLmdv) | `87.50% <ø> (-0.74%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/737/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
jstuever commented 3 months ago

/cc

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, jstuever

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cloud-credential-operator/blob/master/OWNERS)~~ [jstuever] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jcpowermac commented 2 months ago

/hold cancel

openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 5d9a5c8f36ba517e94eef1640e05d6980831ac30 and 2 for PR HEAD 1b3859833d21e23ee2d05c25e35141febc93a766 in total

openshift-ci[bot] commented 2 months ago

@jcpowermac: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cloud-credential-operator This PR has been included in build ose-cloud-credential-operator-container-v4.17.0-202408060344.p0.g2c25ae6.assembly.stream.el9. All builds following this will include this PR.