Closed openshift-cherrypick-robot closed 2 weeks ago
@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-38951 with correct target version. Will retitle the PR to link to the clone. /retitle [release-4.17] OCPBUGS-38952: Follow-up bug fixes for CCO-572
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-38952, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
/jira refresh
@dlom: This pull request references Jira Issue OCPBUGS-38952, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
/refresh
/jira refresh
@dlom: This pull request references Jira Issue OCPBUGS-38952, which is valid. The bug has been moved to the POST state.
Requesting review from QA contact: /cc @jianping-shu
/approve
@jianping-shu This is the backport for the GCP WIF bugfix PR from last week... I believe you already tested it on 4.17 (and previous versions)
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: dlom, openshift-cherrypick-robot
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Attention: Patch coverage is 16.66667%
with 5 lines
in your changes missing coverage. Please review.
Project coverage is 47.27%. Comparing base (
2c25ae6
) to head (97f8d7e
). Report is 4 commits behind head on release-4.17.
Files with missing lines | Patch % | Lines |
---|---|---|
pkg/gcp/actuator/actuator.go | 16.66% | 3 Missing and 2 partials :warning: |
/retest
Verified with test case OCP-75429 /label cherry-pick-approved
/label backport-risk-assessed
@openshift-cherrypick-robot: all tests passed!
Full PR test history. Your PR dashboard.
@openshift-cherrypick-robot: Jira Issue OCPBUGS-38952: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-38952 has been moved to the MODIFIED state.
[ART PR BUILD NOTIFIER]
Distgit: ose-cloud-credential-operator This PR has been included in build ose-cloud-credential-operator-container-v4.17.0-202408282206.p0.g371bd39.assembly.stream.el9. All builds following this will include this PR.
This is an automated cherry-pick of #745
/assign openshift-ci-robot