openshift / cloud-credential-operator

Manage cloud provider credentials as Kubernetes CRDs
Apache License 2.0
62 stars 143 forks source link

[release-4.17] OCPBUGS-38952: Follow-up bug fixes for CCO-572 #751

Closed openshift-cherrypick-robot closed 2 weeks ago

openshift-cherrypick-robot commented 2 weeks ago

This is an automated cherry-pick of #745

/assign openshift-ci-robot

openshift-ci-robot commented 2 weeks ago

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-38951 with correct target version. Will retitle the PR to link to the clone. /retitle [release-4.17] OCPBUGS-38952: Follow-up bug fixes for CCO-572

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/751): >This is an automated cherry-pick of #745 > >/assign openshift-ci-robot Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 weeks ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-38952, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/751): >This is an automated cherry-pick of #745 > >/assign openshift-ci-robot Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dlom commented 2 weeks ago

/jira refresh

openshift-ci-robot commented 2 weeks ago

@dlom: This pull request references Jira Issue OCPBUGS-38952, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/751#issuecomment-2310872174): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dlom commented 2 weeks ago

/refresh

dlom commented 2 weeks ago

/jira refresh

openshift-ci-robot commented 2 weeks ago

@dlom: This pull request references Jira Issue OCPBUGS-38952, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-38951](https://issues.redhat.com//browse/OCPBUGS-38951) is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-38951](https://issues.redhat.com//browse/OCPBUGS-38951) targets the "4.18.0" version, which is one of the valid target versions: 4.18.0 * bug has dependents

Requesting review from QA contact: /cc @jianping-shu

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/751#issuecomment-2310874121): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dlom commented 2 weeks ago

/approve

dlom commented 2 weeks ago

@jianping-shu This is the backport for the GCP WIF bugfix PR from last week... I believe you already tested it on 4.17 (and previous versions)

dlom commented 2 weeks ago

/lgtm

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlom, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cloud-credential-operator/blob/release-4.17/OWNERS)~~ [dlom] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 47.27%. Comparing base (2c25ae6) to head (97f8d7e). Report is 4 commits behind head on release-4.17.

Files with missing lines Patch % Lines
pkg/gcp/actuator/actuator.go 16.66% 3 Missing and 2 partials :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/751/graphs/tree.svg?width=650&height=150&src=pr&token=MSJhsyXrnA&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/751?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## release-4.17 #751 +/- ## ================================================ - Coverage 47.28% 47.27% -0.02% ================================================ Files 96 96 Lines 11712 11717 +5 ================================================ + Hits 5538 5539 +1 - Misses 5563 5565 +2 - Partials 611 613 +2 ``` | [Files with missing lines](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/751?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [pkg/gcp/actuator/actuator.go](https://app.codecov.io/gh/openshift/cloud-credential-operator/pull/751?src=pr&el=tree&filepath=pkg%2Fgcp%2Factuator%2Factuator.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2djcC9hY3R1YXRvci9hY3R1YXRvci5nbw==) | `50.36% <16.66%> (-0.29%)` | :arrow_down: |
dlom commented 2 weeks ago

/retest

jianping-shu commented 2 weeks ago

Verified with test case OCP-75429 /label cherry-pick-approved

dlom commented 2 weeks ago

/label backport-risk-assessed

openshift-ci[bot] commented 2 weeks ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 weeks ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-38952: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-38952 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cloud-credential-operator/pull/751): >This is an automated cherry-pick of #745 > >/assign openshift-ci-robot Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcloud-credential-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

Distgit: ose-cloud-credential-operator This PR has been included in build ose-cloud-credential-operator-container-v4.17.0-202408282206.p0.g371bd39.assembly.stream.el9. All builds following this will include this PR.