search

openshift / cluster-api-provider-libvirt

Apache License 2.0
36 stars 56 forks source link

Bug 1828961: Use virtio disk instead of config drive for injecting ignition for s390x/ppc64le #188

Closed Prashanth684 closed 4 years ago

Prashanth684 commented 4 years ago

Similar to https://github.com/dmacvicar/terraform-provider-libvirt/pull/718

The method of mimicking what Openstack does for injecting ignition config works for images which have the provider as Openstack because ignition recognizes the platform and knows it has to get the ignition config from the config drive. For QEMU images, ignition supports getting the config from the firmware config device which is not supported by ppc64 and s390x.

The workaround we have used thus far is to use the Openstack image on the QEMU platform but have this provider create the iso containing the ignition config. There was a discussion in ignition (coreos/ignition#928) to have a more QEMU based method of injecting ignition config and it was decided to use a virtio-blk device with a serial of ignition which ignition can recognize. This was mainly because with external devices, it is hard to tell if there is an issue with the device or if the kernel has not detected it yet if it has a long discovery phase.

This PR reverts the ISO method used by Openstack and just creates a virtio-blk device through the QEMU command line options.

Reference PR which supports ignition fetching through virtio-blk for QEMU: coreos/ignition#936

Prashanth684 commented 4 years ago

/cc @crawford

zeenix commented 4 years ago

/lgtm

Prashanth684 commented 4 years ago

/retest

Prashanth684 commented 4 years ago

/cherry-pick release-4.4

openshift-cherrypick-robot commented 4 years ago

@Prashanth684: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/188#issuecomment-604963645): >/cherry-pick release-4.4 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
crawford commented 4 years ago

/test e2e-libvirt

crawford commented 4 years ago

/approve

mkumatag commented 4 years ago

/retest

zeenix commented 4 years ago

/test e2e-libvirt

zeenix commented 4 years ago

The e2e-libvirt job won't pass until at least this PR is merged.

Prashanth684 commented 4 years ago

/test e2e-libvirt

Prashanth684 commented 4 years ago

/test e2e-libvirt

Prashanth684 commented 4 years ago

/test e2e-libvirt

crawford commented 4 years ago

/test e2e-libvirt

praveenkumar commented 4 years ago

/retest

crawford commented 4 years ago

Let’s try this again, now that https://github.com/openshift/release/pull/8592 has merged.

/test e2e-libvirt

openshift-ci-robot commented 4 years ago

@Prashanth684: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/actuator-pkg-staleness 614dbb3b5be039af182660f18378ffe63333ef78 link /test actuator-pkg-staleness

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
crawford commented 4 years ago

From the failure:

pods "e2e-dns-utils-q2kss" is forbidden: exec operation is not allowed because the pod's security context exceeds your permissions: pods "e2e-dns-utils-q2kss" is forbidden: securitycontextconstraints.security.openshift.io cache is not synchronized occurred

/test e2e-libvirt

Prashanth684 commented 4 years ago

/retitle Bug 1828961: Use virtio disk instead of config drive for injecting ignition for s390x/ppc64le

openshift-ci-robot commented 4 years ago

@Prashanth684: This pull request references Bugzilla bug 1828961, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/188): >Bug 1828961: Use virtio disk instead of config drive for injecting ignition for s390x/ppc64le Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Prashanth684 commented 4 years ago

/bugzilla refresh

openshift-ci-robot commented 4 years ago

@Prashanth684: This pull request references Bugzilla bug 1828961, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.5.0) matches configured target release for branch (4.5.0) * bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/188#issuecomment-620721997): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
crawford commented 4 years ago

/approve

openshift-ci-robot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: crawford

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/cluster-api-provider-libvirt/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 4 years ago

@Prashanth684: All pull requests linked via external trackers have merged: openshift/cluster-api-provider-libvirt#188. Bugzilla bug 1828961 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/188): >Bug 1828961: Use virtio disk instead of config drive for injecting ignition for s390x/ppc64le Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 4 years ago

@Prashanth684: new pull request created: #191

In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/188#issuecomment-604963645): >/cherry-pick release-4.4 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.