search

openshift / cluster-api-provider-libvirt

Apache License 2.0
36 stars 56 forks source link

Bug 1818149: Use virtio disk instead of config drive for injecting ignition for s390x/ppc64le #189

Closed Prashanth684 closed 4 years ago

Prashanth684 commented 4 years ago

Similar to dmacvicar/terraform-provider-libvirt#718

The method of mimicking what Openstack does for injecting ignition config works for images which have the provider as Openstack because ignition recognizes the platform and knows it has to get the ignition config from the config drive. For QEMU images, ignition supports getting the config from the firmware config device which is not supported by ppc64 and s390x.

The workaround we have used thus far is to use the Openstack image on the QEMU platform but have this provider create the iso containing the ignition config. There was a discussion in ignition (coreos/ignition#928) to have a more QEMU based method of injecting ignition config and it was decided to use a virtio-blk device with a serial of ignition which ignition can recognize. This was mainly because with external devices, it is hard to tell if there is an issue with the device or if the kernel has not detected it yet if it has a long discovery phase.

This PR replaces the the method of ignition injection from a conig drive disk to a virtio-blk device.

Reference PR which supports ignition fetching through virtio-blk for QEMU: coreos/ignition#936

zeenix commented 4 years ago

/hold cancel

openshift-bot commented 4 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 4 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 4 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot commented 4 years ago

@Prashanth684: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/actuator-pkg-staleness 0e27237cb53f97d943bc5e0a49b44c3e0543df27 link /test actuator-pkg-staleness

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
crawford commented 4 years ago

But actuator-pkg-staleness isn't a required test and shouldn't block the merge so not sure what's happening here.

The merge was blocked because this patch is against 4.3 and we only merge into release branches during specific times. Even though the test wasn't required, the bot continued to retest, which was just needlessly using up resources. Now that the release window has opened, I added the cherry-pick-approved label, which will allow this to merge.

openshift-ci-robot commented 4 years ago

@Prashanth684: All pull requests linked via external trackers have merged: openshift/cluster-api-provider-libvirt#189. Bugzilla bug 1818149 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/189): >Bug 1818149: Use virtio disk instead of config drive for injecting ignition for s390x/ppc64le Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.