search

openshift / cluster-api-provider-libvirt

Apache License 2.0
36 stars 56 forks source link

Bug 1936488 : Update MAO and set metrics on :8081 address #218

Closed Prashanth684 closed 3 years ago

Prashanth684 commented 3 years ago

This is to comply with https://github.com/openshift/machine-api-operator/pull/609. Without this change alerts are firing as nobody is listening on port 8081 and the metrics can't be exported.

Co-authored-by: andymcc amccrae@redhat.com

Prashanth684 commented 3 years ago

/retest

cfergeau commented 3 years ago

/lgtm

Prashanth684 commented 3 years ago

/retest

Prashanth684 commented 3 years ago

/lgtm

thanks! mind dropping an approval too @cfergeau ? :)

praveenkumar commented 3 years ago

/approve

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: praveenkumar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-api-provider-libvirt/blob/master/OWNERS)~~ [praveenkumar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yselkowitz commented 3 years ago

/cherry-pick release-4.7

yselkowitz commented 3 years ago

/bugzilla refresh

openshift-cherrypick-robot commented 3 years ago

@yselkowitz: #218 failed to apply on top of branch "release-4.7":

Applying: Update MAO and k8s libraries to use latest
.git/rebase-apply/patch:5324: trailing whitespace.

.git/rebase-apply/patch:5343: trailing whitespace.
of the package can simply change the v-levels for that library. 
.git/rebase-apply/patch:30629: trailing whitespace.
Public functions and structs should normally be named according to the file(s) being read and parsed.  For example, 
.git/rebase-apply/patch:30636: trailing whitespace.
cases reading and parsing should be separated into different functions/methods with a public `fs.Thing()` method and 
.git/rebase-apply/patch:30639: trailing whitespace.
such as `string` or `*File` because it provides the most flexibility regarding the data source.  When a set of files 
error: patch failed: vendor/github.com/sirupsen/logrus/appveyor.yml:1
error: vendor/github.com/sirupsen/logrus/appveyor.yml: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Using index info to reconstruct a base tree...
Patch failed at 0001 Update MAO and k8s libraries to use latest
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/218#issuecomment-797682766): >/cherry-pick release-4.7 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
yselkowitz commented 3 years ago

/bugzilla refresh

Prashanth684 commented 3 years ago

@yselkowitz @andymcc and i discussed this.we need manual backports as we need to match the version of MAO and k8s libs used in 4.7 with other providers rather than just applying this blindly. I am working on this.