search

openshift / cluster-api-provider-libvirt

Apache License 2.0
36 stars 56 forks source link

actuator: cleanup cloudinit and ignition volume on error, bump golang #223

Closed rphillips closed 3 years ago

rphillips commented 3 years ago

I kept getting storage volume 'test1-kbpwl-worker-0-shxhm.ignition' exists already errors on recent installs.

This PR cleans up the cloud-init and ignition volumes on error. Additionally, it bumps golang to 1.16.

praveenkumar commented 3 years ago

cc @Prashanth684

Prashanth684 commented 3 years ago

/test e2e-libvirt

praveenkumar commented 3 years ago

/retest

Prashanth684 commented 3 years ago

/lgtm

cfergeau commented 3 years ago

/lgtm /approve

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-api-provider-libvirt/blob/master/OWNERS)~~ [cfergeau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

cfergeau commented 3 years ago

/retest

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

rphillips commented 3 years ago

/retest

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 3 years ago

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot commented 10 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-libvirt-machine-controllers-container-v4.9.0-202311250023.p0.g59ae2ed.assembly.stream for distgit ose-libvirt-machine-controllers. All builds following this will include this PR.