search

openshift / cluster-api-provider-libvirt

Apache License 2.0
36 stars 56 forks source link

Bug 2018517: Create event only if the machine was modified #230

Closed Fedosin closed 2 years ago

Fedosin commented 2 years ago

Now Libvirt actuator always creates an event after Update, even though the change might not have happened.

To prevent creating fake events we check if the update happens for real and create an event only if it's true.

openshift-ci[bot] commented 2 years ago

@Fedosin: This pull request references Bugzilla bug 2018517, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.10.0) matches configured target release for branch (4.10.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact: /cc @sunzhaohua2

In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/230): >Bug 2018517: Create event only if the machine was modified Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
JoelSpeed commented 2 years ago

/approve

Fedosin commented 2 years ago

Currently blocked by https://github.com/openshift/release/pull/23266

Fedosin commented 2 years ago

/retest

praveenkumar commented 2 years ago

/lgtm /approve

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, praveenkumar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-api-provider-libvirt/blob/master/OWNERS)~~ [praveenkumar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 years ago

@Fedosin: All pull requests linked via external trackers have merged:

Bugzilla bug 2018517 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/230): >Bug 2018517: Create event only if the machine was modified Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.