search

openshift / cluster-api-provider-libvirt

Apache License 2.0
36 stars 56 forks source link

WIP: Migrate to digital libvirt #234

Closed rphillips closed 2 years ago

rphillips commented 2 years ago

This PR migrates the project to use digital ocean's libvirt golang library. The older library has been archived and deprecated. The advantages include fixing the issue where upstream libvirt authors created a backwards incompatible change to the API that required the clients to be updated.

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign frobware after the PR has been reviewed. You can assign the PR to them by writing /assign @frobware in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/cluster-api-provider-libvirt/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rphillips commented 2 years ago

/retest

openshift-ci[bot] commented 2 years ago

@rphillips: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-libvirt a4acfa04973a62b6350d7d4776174c7902a1daaa link false /test e2e-libvirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rphillips commented 2 years ago

e2e-libvirt should pass once the installer gets a RHCOS bump.

cfergeau commented 2 years ago

The older library has been archived and deprecated.

If this is about github.com/libvirt/libvirt-go , the replacement is https://gitlab.com/libvirt/libvirt-go-module

The advantages include fixing the issue where upstream libvirt authors created a backwards incompatible change to the API that required the clients to be updated.

The libvirt client library changes are being backported to RHEL 8.4, which should in turn fix the cluster-api container images so that they work with newer/older libvirt. I'm not sure this PR will work with older libvirt, just with newer ones.

openshift-ci[bot] commented 2 years ago

@rphillips: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.