search

openshift / cluster-api-provider-libvirt

Apache License 2.0
36 stars 56 forks source link

Update container base images #245

Closed cfergeau closed 1 year ago

cfergeau commented 1 year ago

This takes over https://github.com/openshift/cluster-api-provider-libvirt/pull/241 and fixes various issues which start happening when updating to a newer go version.

openshift-merge-robot commented 1 year ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

@cfergeau: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/245): >Update container base images Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from cfergeau by writing /assign @cfergeau in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/cluster-api-provider-libvirt/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 year ago

@cfergeau: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/golint e1eff679deede7aa7ddbf46faf14883b9cb3c750 link true /test golint
ci/prow/gofmt e1eff679deede7aa7ddbf46faf14883b9cb3c750 link true /test gofmt
ci/prow/actuator-pkg-staleness e1eff679deede7aa7ddbf46faf14883b9cb3c750 link false /test actuator-pkg-staleness
ci/prow/e2e-libvirt e1eff679deede7aa7ddbf46faf14883b9cb3c750 link false /test e2e-libvirt
ci/prow/images e1eff679deede7aa7ddbf46faf14883b9cb3c750 link true /test images
ci/prow/unit e1eff679deede7aa7ddbf46faf14883b9cb3c750 link true /test unit
ci/prow/govet e1eff679deede7aa7ddbf46faf14883b9cb3c750 link true /test govet
ci/prow/yaml-lint e1eff679deede7aa7ddbf46faf14883b9cb3c750 link true /test yaml-lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).