openshift / cluster-api-provider-libvirt

Apache License 2.0
36 stars 56 forks source link

Update k8s/vendoring/... #249

Closed cfergeau closed 1 year ago

cfergeau commented 1 year ago

This updates cluster-api-provider-libvirt to use more recent dependencies, and should help with build problems some people have been hitting such as https://github.com/openshift/installer/pull/6812

make test does not pass after these changes, I did not have time to investigate why. This PR should help us get more extensive testing through CI to see exactly how much is non-working.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from cfergeau by writing /assign @cfergeau in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/cluster-api-provider-libvirt/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 year ago

@cfergeau: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit 299279f5e740573b1761c01f52c6d531c2e76817 link true /test unit
ci/prow/e2e-libvirt 299279f5e740573b1761c01f52c6d531c2e76817 link false /test e2e-libvirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
praveenkumar commented 1 year ago

251 is taking all those patches and add another commit to disable actuator unit tests.