Closed cfergeau closed 1 year ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from cfergeau by writing /assign @cfergeau
in a comment. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
@cfergeau: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/unit | 299279f5e740573b1761c01f52c6d531c2e76817 | link | true | /test unit |
ci/prow/e2e-libvirt | 299279f5e740573b1761c01f52c6d531c2e76817 | link | false | /test e2e-libvirt |
Full PR test history. Your PR dashboard.
This updates cluster-api-provider-libvirt to use more recent dependencies, and should help with build problems some people have been hitting such as https://github.com/openshift/installer/pull/6812
make test
does not pass after these changes, I did not have time to investigate why. This PR should help us get more extensive testing through CI to see exactly how much is non-working.