openshift / cluster-api-provider-libvirt

Apache License 2.0
36 stars 56 forks source link

"OCPBUGS-17476: Add workaround for SLOF regression" #263

Closed cfergeau closed 1 year ago

cfergeau commented 1 year ago

A SLOF regression in rhel 8.6 prevents OpenShift libvirt worker nodes from booting. It's easy to workaround if the VM has a serial (non-virtio) device, so this PR tries to add one.

openshift-ci[bot] commented 1 year ago

@cfergeau: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-libvirt d2871e8d3c905087da67e1e47f797a1f4b7e9022 link false /test e2e-libvirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
praveenkumar commented 1 year ago

/assign @cfergeau

cfergeau commented 1 year ago

I tested this on a beaker ppc64le machine, and the worker nodes could get an IP, and I could ssh into them.

gbraad commented 1 year ago

/lgtm

praveenkumar commented 1 year ago

/lgtm /approve

praveenkumar commented 1 year ago

/approved

praveenkumar commented 1 year ago

/approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: praveenkumar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-api-provider-libvirt/blob/master/OWNERS)~~ [praveenkumar] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mkumatag commented 1 year ago

/cherrypick release-4.13

mkumatag commented 1 year ago

/cherrypick release-4.14

openshift-cherrypick-robot commented 1 year ago

@mkumatag: new pull request created: #264

In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/263#issuecomment-1738349757): >/cherrypick release-4.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-cherrypick-robot commented 1 year ago

@mkumatag: new pull request created: #265

In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/263#issuecomment-1738349794): >/cherrypick release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mkumatag commented 1 year ago

/retitle "OCPBUGS-17476: Add workaround for SLOF regression"

openshift-ci-robot commented 1 year ago

@cfergeau: Jira Issue OCPBUGS-17476: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17476 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/263): >A SLOF regression in rhel 8.6 prevents OpenShift libvirt worker nodes from booting. >It's easy to workaround if the VM has a serial (non-virtio) device, so this PR tries to add one. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 10 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-libvirt-machine-controllers-container-v4.15.0-202311202349.p0.g43b2b82.assembly.stream for distgit ose-libvirt-machine-controllers. All builds following this will include this PR.