search

openshift / cluster-api-provider-libvirt

Apache License 2.0
36 stars 56 forks source link

"[release-4.14] client/domain: Remove spice as domain grahics" #266

Closed openshift-cherrypick-robot closed 1 year ago

openshift-cherrypick-robot commented 1 year ago

This is an automated cherry-pick of #260

/assign cfergeau

cfergeau commented 1 year ago

/lgtm

cfergeau commented 1 year ago

/approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-api-provider-libvirt/blob/release-4.14/OWNERS)~~ [cfergeau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mkumatag commented 1 year ago

/test e2e-libvirt

openshift-ci[bot] commented 1 year ago

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-libvirt 162200783ef3957328e4629a7df15bb1b5162f6c link false /test e2e-libvirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
praveenkumar commented 1 year ago

/backport-risk-assessed

praveenkumar commented 1 year ago

/cherry-pick-approved

mkumatag commented 1 year ago

/label cherry-pick-approved

openshift-ci[bot] commented 1 year ago

@mkumatag: Can not set label cherry-pick-approved: Must be member in one of these teams: [openshift-patch-managers openshift-staff-engineers openshift-release-oversight]

In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/266#issuecomment-1740451768): >/label cherry-pick-approved Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mkumatag commented 1 year ago

@praveenkumar @jaypoulz @Prashanth684 can we find someone who can ack this patch?

mkumatag commented 1 year ago

/retitle "OCPBUGS-19926: [release-4.14] client/domain: Remove spice as domain grahics"

openshift-ci-robot commented 1 year ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-19926, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/266): >This is an automated cherry-pick of #260 > >/assign cfergeau Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mkumatag commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@mkumatag: This pull request references Jira Issue OCPBUGS-19926, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/266#issuecomment-1740463376): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mkumatag commented 1 year ago

/retitle "[release-4.14] client/domain: Remove spice as domain grahics"

openshift-ci-robot commented 1 year ago

@openshift-cherrypick-robot: No Jira issue is referenced in the title of this pull request. To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/266): >This is an automated cherry-pick of #260 > >/assign cfergeau Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@openshift-cherrypick-robot: No Jira issue is referenced in the title of this pull request. To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/266): >This is an automated cherry-pick of #260 > >/assign cfergeau Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
cfergeau commented 1 year ago

Closing this, as it's going to be much faster (no backport/jira process to follow for this PR) if we only merge the one patch that we need to fix the regression. /close

openshift-ci[bot] commented 1 year ago

@cfergeau: Closed this PR.

In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/266#issuecomment-1740488558): >Closing this, as it's going to be much faster (no backport/jira process to follow for this PR) if we only merge the one patch that we need to fix the regression. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.