search

openshift / cluster-api-provider-libvirt

Apache License 2.0
36 stars 56 forks source link

[release-4.13] client/domain: Remove spice as domain grahics #267

Closed openshift-cherrypick-robot closed 1 year ago

openshift-cherrypick-robot commented 1 year ago

This is an automated cherry-pick of #260

/assign cfergeau

cfergeau commented 1 year ago

/lgtm

cfergeau commented 1 year ago

/approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-api-provider-libvirt/blob/release-4.13/OWNERS)~~ [cfergeau] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mkumatag commented 1 year ago

/test e2e-libvirt

openshift-ci[bot] commented 1 year ago

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-libvirt 48c57851bee179565ec97d64f1149fabce141080 link false /test e2e-libvirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
praveenkumar commented 1 year ago

/cherry-pick-approved

praveenkumar commented 1 year ago

/backport-risk-assessed

mkumatag commented 1 year ago

e2e is failing with following error, not sure from where this is coming from

error: failed to create/update secret: failed to update secret: Secret "e2e-libvirt" is invalid: data: Too long: must have at most 1048576 bytes
praveenkumar commented 1 year ago

e2e is failing with following error, not sure from where this is coming from

yes, as of now this failure is expected, we need to put effort on openshift/release repo to avoid this Too long error.

mkumatag commented 1 year ago

yes, as of now this failure is expected, we need to put effort on openshift/release repo to avoid this Too long error.

okay, for later. Wondering why those missing labels didn't get added to merge this PR?

cfergeau commented 1 year ago

Closing this, as it's going to be much faster (no backport/jira process to follow for this PR) if we only merge the one patch that we need to fix the regression. /close

openshift-ci[bot] commented 1 year ago

@cfergeau: Closed this PR.

In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/267#issuecomment-1740488351): >Closing this, as it's going to be much faster (no backport/jira process to follow for this PR) if we only merge the one patch that we need to fix the regression. >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.