search

openshift / cluster-api-provider-libvirt

Apache License 2.0
36 stars 56 forks source link

[release-4.12] "OCPBUGS-20026: libvirt: Don't force use of virtio console" #270

Closed openshift-cherrypick-robot closed 7 months ago

openshift-cherrypick-robot commented 1 year ago

This is an automated cherry-pick of #268

/assign mkumatag

openshift-ci-robot commented 1 year ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-19927 has been cloned as Jira Issue OCPBUGS-20026. Will retitle bug to link to clone. /retitle [release-4.12] "OCPBUGS-20026: libvirt: Don't force use of virtio console"

In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/270): >This is an automated cherry-pick of #268 > >/assign mkumatag Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-20026, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/270): >This is an automated cherry-pick of #268 > >/assign mkumatag Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign gbraad for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/cluster-api-provider-libvirt/blob/release-4.12/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
mkumatag commented 1 year ago

/assign cfergeau

openshift-merge-robot commented 1 year ago

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-libvirt 0af9325459e39cb40d51b675d28210fa3447f3cc link false /test e2e-libvirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 1 year ago

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-libvirt 0af9325459e39cb40d51b675d28210fa3447f3cc link false /test e2e-libvirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
mkumatag commented 1 year ago

/cc @Prashanth684

Prashanth684 commented 1 year ago

/label backport-risk-assessed

openshift-ci-robot commented 1 year ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-20026, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.12.z) matches configured target version for branch (4.12.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-19927](https://issues.redhat.com//browse/OCPBUGS-19927) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-19927](https://issues.redhat.com//browse/OCPBUGS-19927) targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z * bug has dependents

Requesting review from QA contact: /cc @gpei

In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/270): >This is an automated cherry-pick of #268 > >/assign mkumatag Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 year ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-20026, which is valid.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.12.z) matches configured target version for branch (4.12.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-19927](https://issues.redhat.com//browse/OCPBUGS-19927) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-19927](https://issues.redhat.com//browse/OCPBUGS-19927) targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z * bug has dependents

Requesting review from QA contact: /cc @gpei

In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/270): >This is an automated cherry-pick of #268 > >/assign mkumatag Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Prashanth684 commented 1 year ago

/label cherry-pick-approved

mkumatag commented 1 year ago

can one of you ack this PR?

/assign @cfergeau @praveenkumar

mkumatag commented 1 year ago

keeping it on hold meanwhile to check if this is really required for the 4.12 or not?

/hold

openshift-bot commented 9 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 8 months ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 7 months ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci[bot] commented 7 months ago

@openshift-bot: Closed this PR.

In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/270#issuecomment-1974946465): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 7 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-20026. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to [this](https://github.com/openshift/cluster-api-provider-libvirt/pull/270): >This is an automated cherry-pick of #268 > >/assign mkumatag Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-api-provider-libvirt). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.