openshift / cluster-debug-tools

Unsupported tools used to investigate broken clusters.
Apache License 2.0
26 stars 28 forks source link

AUTH-330: audit: allow filtering events by pod security admission annotations #37

Closed stlaz closed 1 year ago

stlaz commented 1 year ago

/assign @ibihim /cc @deads2k

deads2k commented 1 year ago

The refactor makes it impossible to allow an event based on the content of other events. I don't care enough to stop it since we always re-introduce the concept. I'll leave the equivalence check to @ibihim

/approve

stlaz commented 1 year ago

I think you might still be able to build a stateful filter with this new pattern, even though it may not be as clean of a solution as before.

ibihim commented 1 year ago

/lgtm

In the context of this repository and PR, the change looks legit.