search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
96 stars 130 forks source link

OCPBUGS-17199: remove revision stability check from bootstrap completeness #1170

Closed tjungblu closed 11 months ago

tjungblu commented 11 months ago

slightly more involved checking against actual node status now, requires further testing against assisted installer and some refactoring.

tjungblu commented 11 months ago

/hold

openshift-ci-robot commented 11 months ago

@tjungblu: This pull request references Jira Issue OCPBUGS-17199, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.0) matches configured target version for branch (4.15.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sandeepknd

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1170): >slightly more involved checking against actual node status now, requires further testing against assisted installer and some refactoring. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tjungblu commented 11 months ago

/test ?

openshift-ci[bot] commented 11 months ago

@tjungblu: The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1170#issuecomment-1830146993): >/test ? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
Elbehery commented 11 months ago

/lgtm /approve

openshift-ci[bot] commented 11 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [Elbehery,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tjungblu commented 11 months ago

/test e2e-metal-assisted

openshift-ci[bot] commented 11 months ago

New changes are detected. LGTM label has been removed.

tjungblu commented 11 months ago

/test e2e-metal-assisted

tjungblu commented 11 months ago

/retest-required

/test e2e-metal-assisted

tjungblu commented 11 months ago

/test e2e-metal-assisted

tjungblu commented 11 months ago

/test e2e-metal-assisted

tjungblu commented 11 months ago

/test e2e-metal-assisted

tjungblu commented 11 months ago

current state functionally works again, let's see if AI installs fine ;)

geliu2016 commented 11 months ago

/label cherry-pick-approved

tjungblu commented 11 months ago

seems to also install fine by AI.

retrying it once more for safety /test e2e-metal-assisted

gotta spend the rest of the day writing tests.

tjungblu commented 11 months ago

/test e2e-metal-assisted

tjungblu commented 11 months ago

/payload 4.15 nightly blocking

openshift-ci[bot] commented 11 months ago

@tjungblu: trigger 8 job(s) of type blocking for the nightly release of OCP 4.15

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3ce7fae0-8f6c-11ee-8d5d-f98f8eed892a-0

tjungblu commented 11 months ago

/hold cancel

tjungblu commented 11 months ago

/test e2e-metal-assisted

openshift-ci[bot] commented 11 months ago

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-qe-no-capabilities f01634d2a48d5823ed3f511d06cff560f7932c9a link true /test e2e-gcp-qe-no-capabilities
ci/prow/e2e-aws-etcd-recovery f01634d2a48d5823ed3f511d06cff560f7932c9a link false /test e2e-aws-etcd-recovery

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
tjungblu commented 11 months ago

/hold

openshift-ci-robot commented 11 months ago

@tjungblu: This pull request references Jira Issue OCPBUGS-17199. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1170): >slightly more involved checking against actual node status now, requires further testing against assisted installer and some refactoring. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.