openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
96 stars 130 forks source link

NO-JIRA: bump library-go and use default UnhealthyPodEvictionPolicy #1171

Closed atiratree closed 10 months ago

atiratree commented 11 months ago

etcd should use a default UnhealthyPodEvictionPolicy behavior corresponding to the IfHealthyBudget policy. This policy achieves the least amount of disruption, as it does not allow eviction when multiple etcd pods do not report readiness. This can block node drain/maintenance. The cluster administrator should then analyze these pods and decide which one to bring down manually.

As opposed to for example to kube-apiserver that can use more permissive eviction policy: https://github.com/openshift/cluster-kube-apiserver-operator/pull/1579

atiratree commented 11 months ago

/retest

atiratree commented 11 months ago

/retest

atiratree commented 11 months ago

/retest

atiratree commented 11 months ago

/retest

Elbehery commented 11 months ago

/retest

Elbehery commented 11 months ago

cc @hasbro17 @dusk125

ingvagabund commented 10 months ago

/retest-required

dusk125 commented 10 months ago

/retest-required /lgtm

openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, dusk125

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [dusk125] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dusk125 commented 10 months ago

This test is being made optional https://github.com/openshift/release/pull/47252 /override ci/prow/e2e-gcp-qe-no-capabilities

openshift-ci[bot] commented 10 months ago

@dusk125: Overrode contexts on behalf of dusk125: ci/prow/e2e-gcp-qe-no-capabilities

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1171#issuecomment-1883187009): >This test is being made optional https://github.com/openshift/release/pull/47252 >/override ci/prow/e2e-gcp-qe-no-capabilities Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ingvagabund commented 10 months ago

/retitle NO-JIRA: bump library-go and use default UnhealthyPodEvictionPolicy

This PR bumps library-go only. The change under pkg/operator/starter.go reflects the new API which is no-op for this operator.

openshift-ci-robot commented 10 months ago

@atiratree: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1171): >etcd should use a default UnhealthyPodEvictionPolicy behavior corresponding to the >IfHealthyBudget policy. This policy achieves the least amount of disruption, as it >does not allow eviction when multiple etcd pods do not report readiness. >This can block node drain/maintenance. The cluster administrator should then >analyze these pods and decide which one to bring down manually. > >As opposed to for example to kube-apiserver that can use more permissive eviction policy: https://github.com/openshift/cluster-kube-apiserver-operator/pull/1579 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 10 months ago

/retest-required

Remaining retests: 0 against base HEAD 9e38f4dd5ada7f72151b4ecac32d9adf5923d536 and 2 for PR HEAD 647af2f5002a4f6c5846e885eb2643916394a21e in total

openshift-ci[bot] commented 10 months ago

@atiratree: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-recovery 647af2f5002a4f6c5846e885eb2643916394a21e link false /test e2e-aws-etcd-recovery

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
ingvagabund commented 10 months ago

/retest-required

openshift-bot commented 10 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.16.0-202401100232.p0.ga13dff1.assembly.stream for distgit cluster-etcd-operator. All builds following this will include this PR.