search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
96 stars 130 forks source link

NO-JIRA: remove cluster-backup pod #1182

Closed lance5890 closed 6 months ago

lance5890 commented 10 months ago

As the UpgradeBackupController has been removed by the PR https://github.com/openshift/cluster-etcd-operator/pull/1129

the cluster-backup-pod has no effect anymore

openshift-ci[bot] commented 10 months ago

Hi @lance5890. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tjungblu commented 10 months ago

/ok-to-test

lance5890 commented 10 months ago

/retest

lance5890 commented 10 months ago

/retest

lance5890 commented 10 months ago

/retest

lance5890 commented 10 months ago

/retest-required

lance5890 commented 10 months ago

/retest

lance5890 commented 10 months ago

/retest

lance5890 commented 10 months ago

/retest

lance5890 commented 10 months ago

/retest

lance5890 commented 10 months ago

/retest

lance5890 commented 10 months ago

/retest

lance5890 commented 10 months ago

/retest

lance5890 commented 10 months ago

/retest

lance5890 commented 9 months ago

prow/e2e-gcp-qe-no-capabilities is being made optional

https://github.com/openshift/release/pull/47252 https://github.com/openshift/release/pull/47890

lance5890 commented 9 months ago

/retest-required

tjungblu commented 9 months ago

Thanks @lance5890! We have to wait until the nightly builds are catching up and the label requirements are lifted, but otherwise

/lgtm

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance5890, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 6 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

lance5890 commented 6 months ago

/remove-lifecycle stale

tjungblu commented 6 months ago

/retitle NO-JIRA: remove cluster-backup pod

openshift-ci-robot commented 6 months ago

@lance5890: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1182): >As the UpgradeBackupController has been removed by the PR https://github.com/openshift/cluster-etcd-operator/pull/1129 > >the cluster-backup-pod has no effect anymore Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tjungblu commented 6 months ago

/jira refresh

openshift-ci-robot commented 6 months ago

@tjungblu: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1182#issuecomment-2085702436): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tjungblu commented 6 months ago

@lance5890 it will likely retest for a while, I'll keep an eye out to get this merged soonish

openshift-ci-robot commented 6 months ago

/retest-required

Remaining retests: 0 against base HEAD 9351543bf82c94384a500d73a4e7b7389ca5a5bf and 2 for PR HEAD 8ed112c9d4cbc52e93f57d8039440d1422fcbe80 in total

tjungblu commented 6 months ago

/override ci/prow/e2e-operator-fips

openshift-ci[bot] commented 6 months ago

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-operator-fips

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1182#issuecomment-2086480033): >/override ci/prow/e2e-operator-fips Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tjungblu commented 6 months ago

/override ci/prow/e2e-agnostic-ovn-upgrade /override ci/prow/e2e-gcp-qe-no-capabilities /override ci/prow/e2e-aws-ovn-single-node

unrelated failures

openshift-ci[bot] commented 6 months ago

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-agnostic-ovn-upgrade, ci/prow/e2e-aws-ovn-single-node, ci/prow/e2e-gcp-qe-no-capabilities

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1182#issuecomment-2086525630): >/override ci/prow/e2e-agnostic-ovn-upgrade >/override ci/prow/e2e-gcp-qe-no-capabilities >/override ci/prow/e2e-aws-ovn-single-node > > >unrelated failures Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 6 months ago

@lance5890: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
tjungblu commented 6 months ago

Thanks @lance5890 and sorry for the long wait

openshift-bot commented 6 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.17.0-202404302014.p0.gcb78ee2.assembly.stream.el9 for distgit cluster-etcd-operator. All builds following this will include this PR.