search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
96 stars 130 forks source link

OCPBUGS-27959: fix panic in health check timeouts #1190

Closed tjungblu closed 9 months ago

openshift-ci-robot commented 9 months ago

@tjungblu: This pull request references Jira Issue OCPBUGS-27959, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1190): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Elbehery commented 9 months ago

/lgtm /approve

tjungblu commented 9 months ago

/jira refresh

openshift-ci-robot commented 9 months ago

@tjungblu: This pull request references Jira Issue OCPBUGS-27959, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @geliu2016

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1190#issuecomment-1916345367): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [Elbehery,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tjungblu commented 9 months ago

fixing a panic I think we can justify setting:

/label acknowledge-critical-fixes-only

/cherry-pick release-4.15

openshift-cherrypick-robot commented 9 months ago

@tjungblu: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1190#issuecomment-1916472505): >fixing a panic I think we can justify setting: > >/label acknowledge-critical-fixes-only > >/cherry-pick release-4.15 > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 9 months ago

/retest-required

Remaining retests: 0 against base HEAD 1e1970f23b7a588953ad47617108a683ecc4f30f and 2 for PR HEAD 1923ea9119b93f35c12f3e228d1b76841f400460 in total

tjungblu commented 9 months ago

/override ci/prow/e2e-gcp-qe-no-capabilities

openshift-ci[bot] commented 9 months ago

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-gcp-qe-no-capabilities

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1190#issuecomment-1916567093): >/override ci/prow/e2e-gcp-qe-no-capabilities Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 9 months ago

@tjungblu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-recovery 1923ea9119b93f35c12f3e228d1b76841f400460 link false /test e2e-aws-etcd-recovery

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 9 months ago

@tjungblu: Jira Issue OCPBUGS-27959: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-27959 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1190): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 9 months ago

@tjungblu: new pull request created: #1191

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1190#issuecomment-1916472505): >fixing a panic I think we can justify setting: > >/label acknowledge-critical-fixes-only > >/cherry-pick release-4.15 > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 9 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.16.0-202401301611.p0.gb93e518.assembly.stream for distgit cluster-etcd-operator. All builds following this will include this PR.