search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
96 stars 130 forks source link

NO-JIRA: replace nodelister with master nodelister #1205

Closed tjungblu closed 9 months ago

tjungblu commented 9 months ago

From profiling on cert rotation we know that the node informer is called every couple of seconds on node heartbeats. This PR will ensure that all our node listers only ever listen/inform on the master node updates to reduce the frequency of unnecessary sync calls.

openshift-ci-robot commented 9 months ago

@tjungblu: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1205): >From profiling on cert rotation we know that the node informer is called every couple of seconds on node heartbeats. This PR will ensure that all our node listers only ever listen/inform on the master node updates to reduce the frequency of unnecessary sync calls. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 9 months ago

/retest-required

Remaining retests: 0 against base HEAD c69979db332bbdd03bc996818c13b0adc8ffe0fb and 2 for PR HEAD ad11d8df70c71bdcc75bc5618faa6587e9706756 in total

openshift-ci-robot commented 9 months ago

/retest-required

Remaining retests: 0 against base HEAD 3fbc7d4ae045871b3c5f08b5106705434f290d07 and 1 for PR HEAD ad11d8df70c71bdcc75bc5618faa6587e9706756 in total

openshift-ci-robot commented 9 months ago

/retest-required

Remaining retests: 0 against base HEAD 9d1553c43c4c85e9cfc8833fecfea70adcfa4589 and 0 for PR HEAD ad11d8df70c71bdcc75bc5618faa6587e9706756 in total

openshift-ci-robot commented 9 months ago

/hold

Revision ad11d8df70c71bdcc75bc5618faa6587e9706756 was retested 3 times: holding

tjungblu commented 9 months ago

/retest-required

tjungblu commented 9 months ago

/hold cancel

tjungblu commented 9 months ago

actually, I think this might conflict with #1186

/hold

tjungblu commented 9 months ago

/retest

tjungblu commented 9 months ago

/hold cancel

@dusk125 could you take another look please? I've rebased to the merged changes in #1186

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [dusk125,tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 9 months ago

@tjungblu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-recovery df7060b3058fcc7614c3ea3ba53ae4f145169659 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-gcp-qe-no-capabilities df7060b3058fcc7614c3ea3ba53ae4f145169659 link false /test e2e-gcp-qe-no-capabilities

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 9 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.16.0-202402141940.p0.g6af658a.assembly.stream.el9 for distgit cluster-etcd-operator. All builds following this will include this PR.

tjungblu commented 8 months ago

/cherry-pick release-4.15

openshift-cherrypick-robot commented 8 months ago

@tjungblu: #1205 failed to apply on top of branch "release-4.15":

Applying: NO-JIRA: replace nodelister with master nodelister
Using index info to reconstruct a base tree...
M   pkg/cmd/render/certs.go
M   pkg/operator/etcdcertsigner/etcdcertsignercontroller.go
M   pkg/operator/etcdcertsigner/etcdcertsignercontroller_test.go
M   pkg/operator/etcdendpointscontroller/etcdendpointscontroller.go
M   pkg/operator/starter.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/operator/starter.go
Auto-merging pkg/operator/etcdendpointscontroller/etcdendpointscontroller.go
Auto-merging pkg/operator/etcdcertsigner/etcdcertsignercontroller_test.go
CONFLICT (content): Merge conflict in pkg/operator/etcdcertsigner/etcdcertsignercontroller_test.go
Auto-merging pkg/operator/etcdcertsigner/etcdcertsignercontroller.go
CONFLICT (content): Merge conflict in pkg/operator/etcdcertsigner/etcdcertsignercontroller.go
Auto-merging pkg/cmd/render/certs.go
CONFLICT (content): Merge conflict in pkg/cmd/render/certs.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 NO-JIRA: replace nodelister with master nodelister
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1205#issuecomment-1954159017): >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.