search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
96 stars 130 forks source link

[release-4.14] OCPBUGS-30012: Replace nodelister with master nodelister everywhere #1211

Closed openshift-cherrypick-robot closed 8 months ago

openshift-cherrypick-robot commented 8 months ago

This is an automated cherry-pick of #1206

/assign tjungblu

openshift-ci-robot commented 8 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-29717 has been cloned as Jira Issue OCPBUGS-30012. Will retitle bug to link to clone. /retitle [release-4.14] OCPBUGS-30012: [4.15] Replace nodelister with master nodelister everywhere

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1211): >This is an automated cherry-pick of #1206 > >/assign tjungblu Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 8 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-30012, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1211): >This is an automated cherry-pick of #1206 > >/assign tjungblu Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 8 months ago

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn-etcd-scaling 57100836893b5051a78418b36455714ea1ac6b84 link false /test e2e-gcp-ovn-etcd-scaling
ci/prow/e2e-aws-etcd-recovery 57100836893b5051a78418b36455714ea1ac6b84 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-gcp-qe-no-capabilities 57100836893b5051a78418b36455714ea1ac6b84 link false /test e2e-gcp-qe-no-capabilities

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
tjungblu commented 8 months ago

/cherry-pick release-4.13

openshift-cherrypick-robot commented 8 months ago

@tjungblu: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1211#issuecomment-1968399536): >/cherry-pick release-4.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
hasbro17 commented 8 months ago

/lgtm /label backport-risk-assessed /retest-required

tjungblu commented 8 months ago

/jira refresh

openshift-ci-robot commented 8 months ago

@tjungblu: This pull request references Jira Issue OCPBUGS-30012, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.z) matches configured target version for branch (4.14.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-29717](https://issues.redhat.com//browse/OCPBUGS-29717) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-29717](https://issues.redhat.com//browse/OCPBUGS-29717) targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z * bug has dependents

Requesting review from QA contact: /cc @geliu2016

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1211#issuecomment-1970727866): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tjungblu commented 8 months ago

/cherry-pick release-4.13

openshift-cherrypick-robot commented 8 months ago

@tjungblu: once the present PR merges, I will cherry-pick it on top of release-4.13 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1211#issuecomment-1970728183): >/cherry-pick release-4.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
tjungblu commented 8 months ago

/retitle [release-4.14] OCPBUGS-30012: Replace nodelister with master nodelister everywhere

Elbehery commented 8 months ago

/retest-required

Elbehery commented 8 months ago

/lgtm /approve

Elbehery commented 8 months ago

/label cherry-pick-approved

openshift-ci[bot] commented 8 months ago

@Elbehery: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1211#issuecomment-1970960791): >/label cherry-pick-approved Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, geliu2016, hasbro17, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/release-4.14/OWNERS)~~ [Elbehery,hasbro17] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 8 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-30012: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30012 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1211): >This is an automated cherry-pick of #1206 > >/assign tjungblu Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 8 months ago

@tjungblu: #1211 failed to apply on top of branch "release-4.13":

Applying: OCPBUGS-29717: Replace nodelister with master nodelister everywhere
Using index info to reconstruct a base tree...
M   pkg/etcdenvvar/envvarcontroller.go
M   pkg/etcdenvvar/envvarcontroller_test.go
M   pkg/etcdenvvar/etcd_env.go
M   pkg/operator/etcdcertsigner/etcdcertsignercontroller.go
M   pkg/operator/starter.go
M   pkg/operator/targetconfigcontroller/targetconfigcontroller.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/operator/targetconfigcontroller/targetconfigcontroller.go
Auto-merging pkg/operator/starter.go
CONFLICT (content): Merge conflict in pkg/operator/starter.go
Auto-merging pkg/operator/etcdcertsigner/etcdcertsignercontroller.go
Auto-merging pkg/etcdenvvar/etcd_env.go
CONFLICT (content): Merge conflict in pkg/etcdenvvar/etcd_env.go
Auto-merging pkg/etcdenvvar/envvarcontroller_test.go
Auto-merging pkg/etcdenvvar/envvarcontroller.go
CONFLICT (content): Merge conflict in pkg/etcdenvvar/envvarcontroller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-29717: Replace nodelister with master nodelister everywhere
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1211#issuecomment-1970728183): >/cherry-pick release-4.13 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 8 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.14.0-202403010609.p0.g2bb59cd.assembly.stream.el8 for distgit cluster-etcd-operator. All builds following this will include this PR.

openshift-merge-robot commented 8 months ago

Fix included in accepted release 4.14.0-0.nightly-2024-03-01-191450

tjungblu commented 8 months ago

/jira clone

tjungblu commented 8 months ago

/jira ?