search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
96 stars 130 forks source link

[release-4.12] OCPBUGS-30914: Replace nodelister with master nodelister everywhere #1224

Closed openshift-cherrypick-robot closed 7 months ago

openshift-cherrypick-robot commented 8 months ago

This is an automated cherry-pick of #1216

/assign tjungblu

openshift-ci-robot commented 8 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-30245 has been cloned as Jira Issue OCPBUGS-30914. Will retitle bug to link to clone. /retitle [release-4.12] OCPBUGS-30914: [4.13] Replace nodelister with master nodelister everywhere

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1224): >This is an automated cherry-pick of #1216 > >/assign tjungblu Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 8 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-30914, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1224): >This is an automated cherry-pick of #1216 > >/assign tjungblu Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tjungblu commented 8 months ago

/retitle [release-4.12] OCPBUGS-30914: Replace nodelister with master nodelister everywhere

Elbehery commented 8 months ago

/lgtm /approve

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Elbehery, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/release-4.12/OWNERS)~~ [Elbehery] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
tjungblu commented 8 months ago

/jira refresh

openshift-ci-robot commented 8 months ago

@tjungblu: This pull request references Jira Issue OCPBUGS-30914, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.12.z) matches configured target version for branch (4.12.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-30245](https://issues.redhat.com//browse/OCPBUGS-30245) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-30245](https://issues.redhat.com//browse/OCPBUGS-30245) targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z * bug has dependents

Requesting review from QA contact: /cc @geliu2016

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1224#issuecomment-1999125462): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tjungblu commented 8 months ago

/label backport-risk-assessed

tjungblu commented 7 months ago

/jira refresh

openshift-ci-robot commented 7 months ago

@tjungblu: This pull request references Jira Issue OCPBUGS-30914, which is valid.

6 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.12.z) matches configured target version for branch (4.12.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * dependent bug [Jira Issue OCPBUGS-30245](https://issues.redhat.com//browse/OCPBUGS-30245) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-30245](https://issues.redhat.com//browse/OCPBUGS-30245) targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z * bug has dependents

Requesting review from QA contact: /cc @geliu2016

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1224#issuecomment-2020121010): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
tjungblu commented 7 months ago

/retest

tjungblu commented 7 months ago

@geliu2016 / @sandeepknd could you guys add the CPA label please?

sandeepknd commented 7 months ago

/label cherry-pick-approved

openshift-ci-robot commented 7 months ago

/retest-required

Remaining retests: 0 against base HEAD 7280e4f3b8d2fa3663ef0728ed031b1670ad8d27 and 2 for PR HEAD c307de574228de037c2c1614a152dd76b55429aa in total

tjungblu commented 7 months ago

/retest

openshift-ci-robot commented 7 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-30914: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30914 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1224): >This is an automated cherry-pick of #1216 > >/assign tjungblu Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 7 months ago

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-disruptive-ovn c307de574228de037c2c1614a152dd76b55429aa link false /test e2e-gcp-disruptive-ovn
ci/prow/e2e-aws-etcd-recovery c307de574228de037c2c1614a152dd76b55429aa link false /test e2e-aws-etcd-recovery
ci/prow/e2e-aws-disruptive-ovn c307de574228de037c2c1614a152dd76b55429aa link false /test e2e-aws-disruptive-ovn
ci/prow/e2e-gcp-qe-no-capabilities c307de574228de037c2c1614a152dd76b55429aa link false /test e2e-gcp-qe-no-capabilities

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
Elbehery commented 7 months ago

/retest-required

openshift-bot commented 7 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.12.0-202403281339.p0.g9b5cf74.assembly.stream.el8 for distgit cluster-etcd-operator. All builds following this will include this PR.

openshift-merge-robot commented 7 months ago

Fix included in accepted release 4.12.0-0.nightly-2024-03-28-201232