search

openshift / cluster-etcd-operator

Operator to manage the lifecycle of the etcd members of an OpenShift cluster
Apache License 2.0
96 stars 130 forks source link

OCPBUGS-31658: Fix feature set custom no upgrade #1233

Closed vr4manta closed 7 months ago

vr4manta commented 7 months ago

OCPBUGS-31658

Changes

Notes

Altinfra tests have been failing due to use of CustomNoUpgrade feature set. The etcd operator's CRD is not being installed for CustomNoUpgrade due to the CustomNoUpgrade manifest missing.

vr4manta commented 7 months ago

/payload-job pull-ci-openshift-installer-master-altinfra-e2e-vsphere-capi-ovn

openshift-ci[bot] commented 7 months ago

@vr4manta: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

openshift-ci-robot commented 7 months ago

@vr4manta: This pull request references Jira Issue OCPBUGS-31658, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1233): >[OCPBUGS-31658](https://issues.redhat.com/browse/OCPBUGS-31658) > >### Changes >- Updated API to get new manifests >- Updated dockerfile to use new manifest files > >### Notes >Altinfra tests have been failing due to use of CustomNoUpgrade feature set. The etcd operator's CRD is not being installed for CustomNoUpgrade due to the CustomNoUpgrade manifest missing. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vr4manta commented 7 months ago

/jira refresh

openshift-ci-robot commented 7 months ago

@vr4manta: This pull request references Jira Issue OCPBUGS-31658, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @geliu2016

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1233#issuecomment-2032998186): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vr4manta commented 7 months ago

/retest-required

vr4manta commented 7 months ago

/assign @hasbro17 Some tests are failing but I do not think they are related to these changes. Let me know your thoughts.

openshift-ci[bot] commented 7 months ago

@vr4manta: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-etcd-recovery 9e9164bd427b2842c87c9e3a136fad3aa2fc9a51 link false /test e2e-aws-etcd-recovery
ci/prow/e2e-gcp-qe-no-capabilities 9e9164bd427b2842c87c9e3a136fad3aa2fc9a51 link false /test e2e-gcp-qe-no-capabilities

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
tjungblu commented 7 months ago

Thanks for fixing it, I'm not sure what went missing in the first place, but I don't want to hold this up any longer for you folks.

/approve

unrelated test failures:

/override ci/prow/e2e-aws-ovn-etcd-scaling /override ci/prow/e2e-operator-fips

openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geliu2016, tjungblu, vr4manta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/cluster-etcd-operator/blob/master/OWNERS)~~ [tjungblu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 7 months ago

@tjungblu: Overrode contexts on behalf of tjungblu: ci/prow/e2e-aws-ovn-etcd-scaling, ci/prow/e2e-operator-fips

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1233#issuecomment-2039082599): >Thanks for fixing it, I'm not sure what went missing in the first place, but I don't want to hold this up any longer for you folks. > >/approve > >unrelated test failures: > >/override ci/prow/e2e-aws-ovn-etcd-scaling >/override ci/prow/e2e-operator-fips > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 7 months ago

@vr4manta: Jira Issue OCPBUGS-31658: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31658 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/cluster-etcd-operator/pull/1233): >[OCPBUGS-31658](https://issues.redhat.com/browse/OCPBUGS-31658) > >### Changes >- Updated API to get new manifests >- Updated dockerfile to use new manifest files > >### Notes >Altinfra tests have been failing due to use of CustomNoUpgrade feature set. The etcd operator's CRD is not being installed for CustomNoUpgrade due to the CustomNoUpgrade manifest missing. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fcluster-etcd-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 7 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build cluster-etcd-operator-container-v4.16.0-202404050447.p0.g3d5483e.assembly.stream.el9 for distgit cluster-etcd-operator. All builds following this will include this PR.

openshift-merge-robot commented 7 months ago

Fix included in accepted release 4.16.0-0.nightly-2024-04-05-200353